diff options
| author | Mohammed Anees <[email protected]> | 2024-10-09 12:28:31 +0000 |
|---|---|---|
| committer | Alex Deucher <[email protected]> | 2024-10-15 15:18:49 +0000 |
| commit | 40f2cd98828f454bdc5006ad3d94330a5ea164b7 (patch) | |
| tree | 7319b1c13869c78801d3715efe08e0e948855fd1 /drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | |
| parent | drm/amd/pm: Fill pcie recov cntr to metrics 1.6 (diff) | |
| download | kernel-40f2cd98828f454bdc5006ad3d94330a5ea164b7.tar.gz kernel-40f2cd98828f454bdc5006ad3d94330a5ea164b7.zip | |
drm/amdgpu: prevent BO_HANDLES error from being overwritten
Before this patch, if multiple BO_HANDLES chunks were submitted,
the error -EINVAL would be correctly set but could be overwritten
by the return value from amdgpu_cs_p1_bo_handles(). This patch
ensures that if there are multiple BO_HANDLES, we stop.
Fixes: fec5f8e8c6bc ("drm/amdgpu: disallow multiple BO_HANDLES chunks in one submit")
Signed-off-by: Mohammed Anees <[email protected]>
Reviewed-by: Christian König <[email protected]>
Signed-off-by: Pierre-Eric Pelloux-Prayer <[email protected]>
Signed-off-by: Alex Deucher <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c')
| -rw-r--r-- | drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c index 1e475eb01417..d891ab779ca7 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c @@ -265,7 +265,7 @@ static int amdgpu_cs_pass1(struct amdgpu_cs_parser *p, /* Only a single BO list is allowed to simplify handling. */ if (p->bo_list) - ret = -EINVAL; + goto free_partial_kdata; ret = amdgpu_cs_p1_bo_handles(p, p->chunks[i].kdata); if (ret) |