diff options
| author | Ammar Faizi <[email protected]> | 2025-08-06 00:31:05 +0000 |
|---|---|---|
| committer | Linus Torvalds <[email protected]> | 2025-08-06 01:39:42 +0000 |
| commit | 8466d393700f9ccef68134d3349f4e0a087679b9 (patch) | |
| tree | 3f0e0aadb158f75a167931d0a4ede85d7aade344 /drivers/gpu/drm/amd/amdgpu/amdgpu_cper.c | |
| parent | Merge tag 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rmk/linux (diff) | |
| download | kernel-8466d393700f9ccef68134d3349f4e0a087679b9.tar.gz kernel-8466d393700f9ccef68134d3349f4e0a087679b9.zip | |
net: usbnet: Fix the wrong netif_carrier_on() call
The commit referenced in the Fixes tag causes usbnet to malfunction
(identified via git bisect). Post-commit, my external RJ45 LAN cable
fails to connect. Linus also reported the same issue after pulling that
commit.
The code has a logic error: netif_carrier_on() is only called when the
link is already on. Fix this by moving the netif_carrier_on() call
outside the if-statement entirely. This ensures it is always called
when EVENT_LINK_CARRIER_ON is set and properly clears it regardless
of the link state.
Cc: [email protected]
Cc: Armando Budianto <[email protected]>
Reviewed-by: Simon Horman <[email protected]>
Suggested-by: Linus Torvalds <[email protected]>
Link: https://lore.kernel.org/all/CAHk-=wjqL4uF0MG_c8+xHX1Vv8==sPYQrtzbdA3kzi96284nuQ@mail.gmail.com
Closes: https://lore.kernel.org/netdev/CAHk-=wjKh8X4PT_mU1kD4GQrbjivMfPn-_hXa6han_BTDcXddw@mail.gmail.com
Closes: https://lore.kernel.org/netdev/[email protected]
Fixes: 0d9cfc9b8cb1 ("net: usbnet: Avoid potential RCU stall on LINK_CHANGE event")
Signed-off-by: Ammar Faizi <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_cper.c')
0 files changed, 0 insertions, 0 deletions