diff options
| author | Ma Ke <[email protected]> | 2024-07-18 14:11:41 +0000 |
|---|---|---|
| committer | Alex Deucher <[email protected]> | 2024-07-23 21:33:25 +0000 |
| commit | 93381e6b61804b777f60357d96d6254eb10b9b56 (patch) | |
| tree | d2b795a543fc2dfb27c0f8117741810d9e9edac8 /drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | |
| parent | drm/amdgpu: Fix atomics on GFX12 (diff) | |
| download | kernel-93381e6b61804b777f60357d96d6254eb10b9b56.tar.gz kernel-93381e6b61804b777f60357d96d6254eb10b9b56.zip | |
drm/amdgpu: fix a possible null pointer dereference
In amdgpu_connector_add_common_modes(), the return value of drm_cvt_mode()
is assigned to mode, which will lead to a NULL pointer dereference on
failure of drm_cvt_mode(). Add a check to avoid npd.
Cc: [email protected]
Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")
Signed-off-by: Ma Ke <[email protected]>
Signed-off-by: Alex Deucher <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c')
| -rw-r--r-- | drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c index cae7479c3ecf..bd0fbdc5f55d 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c @@ -442,6 +442,9 @@ static void amdgpu_connector_add_common_modes(struct drm_encoder *encoder, continue; mode = drm_cvt_mode(dev, common_modes[i].w, common_modes[i].h, 60, false, false, false); + if (!mode) + return; + drm_mode_probed_add(connector, mode); } } |