diff options
| author | Arnd Bergmann <[email protected]> | 2017-11-02 11:25:39 +0000 |
|---|---|---|
| committer | Alex Deucher <[email protected]> | 2017-11-03 13:42:28 +0000 |
| commit | e477e940dad1836c6f6d23353e424665b9316b6e (patch) | |
| tree | ff281ae5c9913f1481f786ea677aeb06cdcec940 /drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | |
| parent | Merge branch 'linux-4.15' of git://github.com/skeggsb/linux into drm-next (diff) | |
| download | kernel-e477e940dad1836c6f6d23353e424665b9316b6e.tar.gz kernel-e477e940dad1836c6f6d23353e424665b9316b6e.zip | |
drm/amdgpu/virt: don't dereference undefined 'module' struct
Accessing the THIS_MODULE directly is only possible when modules
are enabled, otherwise we get a build failure:
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c: In function 'amdgpu_virt_init_data_exchange':
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:331:20: error: dereferencing pointer to incomplete type 'struct module'
Further, THIS_MODULE is NULL when the driver is built-in, so the
code would likely cause a NULL pointer dereference.
This adds an #ifdef check to avoid the compile-time error, plus
a NULL pointer check before dereferencing THIS_MODULE. It might
be better to find a way to avoid using the module version
altogether.
Fixes: 2dc8f81e4f82 ("drm/amdgpu: SR-IOV data exchange between PF&VF")
Signed-off-by: Arnd Bergmann <[email protected]>
Signed-off-by: Alex Deucher <[email protected]>
Reviewed-by: Harry Wentland <[email protected]>
Reviewed-By: Xiangliang Yu <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c')
0 files changed, 0 insertions, 0 deletions
