diff options
| author | Andy Shevchenko <[email protected]> | 2025-04-16 09:55:09 +0000 |
|---|---|---|
| committer | Bartosz Golaszewski <[email protected]> | 2025-04-17 13:22:05 +0000 |
| commit | f1d6cd0774bc211429ebf24187dc3d271feb5ed6 (patch) | |
| tree | 78269cc3e75587417ca30dc23dff5eaec2205ccf /drivers/gpio/gpiolib.c | |
| parent | gpio: spacemit: add support for K1 SoC (diff) | |
| download | kernel-f1d6cd0774bc211429ebf24187dc3d271feb5ed6.tar.gz kernel-f1d6cd0774bc211429ebf24187dc3d271feb5ed6.zip | |
gpiolib: Make taking gpio_lookup_lock consistent
There are two ways to take a lock: plain call to the mutex_lock()
or using guard()() / scoped_guard(). The driver inconsistently uses
both. Make taking gpio_lookup_lock consistent.
Reviewed-by: Linus Walleij <[email protected]>
Signed-off-by: Andy Shevchenko <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Bartosz Golaszewski <[email protected]>
Diffstat (limited to 'drivers/gpio/gpiolib.c')
| -rw-r--r-- | drivers/gpio/gpiolib.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index f208901ba478..40ae0e09fb9f 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -4363,12 +4363,10 @@ void gpiod_add_lookup_tables(struct gpiod_lookup_table **tables, size_t n) { unsigned int i; - mutex_lock(&gpio_lookup_lock); + guard(mutex)(&gpio_lookup_lock); for (i = 0; i < n; i++) list_add_tail(&tables[i]->list, &gpio_lookup_list); - - mutex_unlock(&gpio_lookup_lock); } /** @@ -4427,11 +4425,9 @@ void gpiod_remove_lookup_table(struct gpiod_lookup_table *table) if (!table) return; - mutex_lock(&gpio_lookup_lock); + guard(mutex)(&gpio_lookup_lock); list_del(&table->list); - - mutex_unlock(&gpio_lookup_lock); } EXPORT_SYMBOL_GPL(gpiod_remove_lookup_table); |