diff options
| author | Linus Walleij <[email protected]> | 2016-02-12 08:22:11 +0000 |
|---|---|---|
| committer | Linus Walleij <[email protected]> | 2016-02-15 23:19:54 +0000 |
| commit | 4e6fd26dcf5d70a7700a4c15d8f239103bdce91d (patch) | |
| tree | 8e86749506bdcea2a07243f7e4efaaf462ce865e /drivers/gpio/gpio-mpc5200.c | |
| parent | gpio: ws16c48: Use devm_request_region (diff) | |
| download | kernel-4e6fd26dcf5d70a7700a4c15d8f239103bdce91d.tar.gz kernel-4e6fd26dcf5d70a7700a4c15d8f239103bdce91d.zip | |
pinctrl: sirf/atlas7: stop poking around in GPIO internals
This code is poking around in the gpio_chip:s internal structures
to achieve some kind of pin to GPIO mappings.
- It is wrong to poke around in these structs and the pinctrl
maintainer was stupid to let it pass unnoticed, mea culpa.
- The right interface to use is gpiochip_add_pin_range()
- The code appears unused: the pin control part of the driver
is not adding any ranges, so we're iterating over an empty
list. Maybe it is poking around in some other pin controllers
GPIO ranges, and that's just totally wrong, again use
gpiochip_add_pin_range() and specify the right pin
controller.
Cc: Barry Song <[email protected]>
Cc: Guoying Zhang <[email protected]>
Cc: Wei Chen <[email protected]>
Signed-off-by: Linus Walleij <[email protected]>
Diffstat (limited to 'drivers/gpio/gpio-mpc5200.c')
0 files changed, 0 insertions, 0 deletions