diff options
| author | Xu Yilun <[email protected]> | 2025-08-06 07:06:05 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2025-08-19 10:54:45 +0000 |
| commit | 1ca61060de92a4320d73adfe5dc8d335653907ac (patch) | |
| tree | 73e0ae942d4a53237b90cfbe39b87055310b07ee /drivers/fpga/zynq-fpga.c | |
| parent | Linux 6.17-rc2 (diff) | |
| download | kernel-1ca61060de92a4320d73adfe5dc8d335653907ac.tar.gz kernel-1ca61060de92a4320d73adfe5dc8d335653907ac.zip | |
fpga: zynq_fpga: Fix the wrong usage of dma_map_sgtable()
dma_map_sgtable() returns only 0 or the error code. Read sgt->nents to
get the number of mapped segments.
Fixes: 37e00703228a ("zynq_fpga: use sgtable-based scatterlist wrappers")
Reported-by: Pavel Pisa <[email protected]>
Closes: https://lore.kernel.org/linux-fpga/[email protected]/
Reviewed-by: Jason Gunthorpe <[email protected]>
Reviewed-by: Marek Szyprowski <[email protected]>
Signed-off-by: Xu Yilun <[email protected]>
Tested-by: Pavel Pisa <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'drivers/fpga/zynq-fpga.c')
| -rw-r--r-- | drivers/fpga/zynq-fpga.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c index 0be0d569589d..b7629a0e4813 100644 --- a/drivers/fpga/zynq-fpga.c +++ b/drivers/fpga/zynq-fpga.c @@ -405,12 +405,12 @@ static int zynq_fpga_ops_write(struct fpga_manager *mgr, struct sg_table *sgt) } } - priv->dma_nelms = - dma_map_sgtable(mgr->dev.parent, sgt, DMA_TO_DEVICE, 0); - if (priv->dma_nelms == 0) { + err = dma_map_sgtable(mgr->dev.parent, sgt, DMA_TO_DEVICE, 0); + if (err) { dev_err(&mgr->dev, "Unable to DMA map (TO_DEVICE)\n"); - return -ENOMEM; + return err; } + priv->dma_nelms = sgt->nents; /* enable clock */ err = clk_enable(priv->clk); |