fpga manager: xilinx-spi: fix write_complete timeout handling

If this routine sleeps because it was scheduled out, it might miss DONE
going asserted and consider it a timeout. This would potentially make the
code return an error even when programming succeeded. Rewrite the loop to
always check DONE after checking if timeout expired so this cannot happen
anymore.

While there, also add error checking for gpiod_get_value(). Also avoid
checking the DONE GPIO in two places, which would make the error-checking
code duplicated and more annoying.

The new loop it written to still guarantee that we apply 8 extra CCLK
cycles after DONE has gone asserted, which is required by the hardware.

Reported-by: Tom Rix <[email protected]>
Reviewed-by: Tom Rix <[email protected]>
Signed-off-by: Luca Ceresoli <[email protected]>
Signed-off-by: Moritz Fischer <[email protected]>

0 files changed, 0 insertions, 0 deletions