aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/fpga/fpga-bridge.c
diff options
context:
space:
mode:
authorHao Xu <[email protected]>2021-09-22 10:12:38 +0000
committerJens Axboe <[email protected]>2021-09-24 16:24:34 +0000
commit5b7aa38d86f348847a48f71e9ac7715406de900e (patch)
treef564a01423b873890b12f8c170858e7f2020334d /drivers/fpga/fpga-bridge.c
parentio_uring: fix missing set of EPOLLONESHOT for CQ ring overflow (diff)
downloadkernel-5b7aa38d86f348847a48f71e9ac7715406de900e.tar.gz
kernel-5b7aa38d86f348847a48f71e9ac7715406de900e.zip
io_uring: fix potential req refcount underflow
For multishot mode, there may be cases like: iowq original context io_poll_add _arm_poll() mask = vfs_poll() is not 0 if mask (2) io_poll_complete() compl_unlock (interruption happens tw queued to original context) io_poll_task_func() compl_lock (3) done = io_poll_complete() is true compl_unlock put req ref (1) if (poll->flags & EPOLLONESHOT) put req ref EPOLLONESHOT flag in (1) may be from (2) or (3), so there are multiple combinations that can cause ref underfow. Let's address it by: - check the return value in (2) as done - change (1) to if (done) in this way, we only do ref put in (1) if 'oneshot flag' is from (2) - do poll.done check in io_poll_task_func(), so that we won't put ref for the second time. Signed-off-by: Hao Xu <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jens Axboe <[email protected]>
Diffstat (limited to 'drivers/fpga/fpga-bridge.c')
0 files changed, 0 insertions, 0 deletions