diff options
| author | Qais Yousef <[email protected]> | 2020-03-23 13:51:07 +0000 |
|---|---|---|
| committer | Thomas Gleixner <[email protected]> | 2020-03-25 11:59:37 +0000 |
| commit | 20fb50295b139494754964d7d005b5a2f465ef08 (patch) | |
| tree | 7af6d45699b14176d2100d494ed6075ed6d9b121 /drivers/firmware/psci/psci_checker.c | |
| parent | xen/cpuhotplug: Replace cpu_up/down() with device_online/offline() (diff) | |
| download | kernel-20fb50295b139494754964d7d005b5a2f465ef08.tar.gz kernel-20fb50295b139494754964d7d005b5a2f465ef08.zip | |
firmware: psci: Replace cpu_up/down() with add/remove_cpu()
The core device API performs extra housekeeping bits that are missing
from directly calling cpu_up/down().
See commit a6717c01ddc2 ("powerpc/rtas: use device model APIs and
serialization during LPM") for an example description of what might go
wrong.
This also prepares to make cpu_up/down a private interface of the CPU subsystem.
Signed-off-by: Qais Yousef <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Cc: Lorenzo Pieralisi <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
Diffstat (limited to 'drivers/firmware/psci/psci_checker.c')
| -rw-r--r-- | drivers/firmware/psci/psci_checker.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/firmware/psci/psci_checker.c b/drivers/firmware/psci/psci_checker.c index 6a445397771c..873841af8d57 100644 --- a/drivers/firmware/psci/psci_checker.c +++ b/drivers/firmware/psci/psci_checker.c @@ -84,7 +84,7 @@ static unsigned int down_and_up_cpus(const struct cpumask *cpus, /* Try to power down all CPUs in the mask. */ for_each_cpu(cpu, cpus) { - int ret = cpu_down(cpu); + int ret = remove_cpu(cpu); /* * cpu_down() checks the number of online CPUs before the TOS @@ -116,7 +116,7 @@ static unsigned int down_and_up_cpus(const struct cpumask *cpus, /* Try to power up all the CPUs that have been offlined. */ for_each_cpu(cpu, offlined_cpus) { - int ret = cpu_up(cpu); + int ret = add_cpu(cpu); if (ret != 0) { pr_err("Error occurred (%d) while trying " |