diff options
| author | Anthony Iliopoulos <[email protected]> | 2025-02-04 23:18:21 +0000 |
|---|---|---|
| committer | Madhavan Srinivasan <[email protected]> | 2025-04-15 06:10:54 +0000 |
| commit | 534f5a8ba27863141e29766467a3e1f61bcb47ac (patch) | |
| tree | d85dfb4b2e99c02db816cfd7e057870981b24d77 /drivers/firmware/psci/psci.c | |
| parent | book3s64/radix : Align section vmemmap start address to PAGE_SIZE (diff) | |
| download | kernel-534f5a8ba27863141e29766467a3e1f61bcb47ac.tar.gz kernel-534f5a8ba27863141e29766467a3e1f61bcb47ac.zip | |
powerpc64/ftrace: fix module loading without patchable function entries
get_stubs_size assumes that there must always be at least one patchable
function entry, which is not always the case (modules that export data
but no code), otherwise it returns -ENOEXEC and thus the section header
sh_size is set to that value. During module_memory_alloc() the size is
passed to execmem_alloc() after being page-aligned and thus set to zero
which will cause it to fail the allocation (and thus module loading) as
__vmalloc_node_range() checks for zero-sized allocs and returns null:
[ 115.466896] module_64: cast_common: doesn't contain __patchable_function_entries.
[ 115.469189] ------------[ cut here ]------------
[ 115.469496] WARNING: CPU: 0 PID: 274 at mm/vmalloc.c:3778 __vmalloc_node_range_noprof+0x8b4/0x8f0
...
[ 115.478574] ---[ end trace 0000000000000000 ]---
[ 115.479545] execmem: unable to allocate memory
Fix this by removing the check completely, since it is anyway not
helpful to propagate this as an error upwards.
Fixes: eec37961a56a ("powerpc64/ftrace: Move ftrace sequence out of line")
Signed-off-by: Anthony Iliopoulos <[email protected]>
Acked-by: Naveen N Rao (AMD) <[email protected]>
Signed-off-by: Madhavan Srinivasan <[email protected]>
Link: https://patch.msgid.link/[email protected]
Diffstat (limited to 'drivers/firmware/psci/psci.c')
0 files changed, 0 insertions, 0 deletions
