aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/crypto/inside-secure/safexcel_cipher.c
diff options
context:
space:
mode:
authorEric Biggers <[email protected]>2020-07-10 06:20:39 +0000
committerHerbert Xu <[email protected]>2020-07-16 11:49:08 +0000
commit2eb27c11937ee9984c04b75d213a737291c5f58c (patch)
tree1665e908ce8a0e7e153fe9f77b2ddca77867c7dc /drivers/crypto/inside-secure/safexcel_cipher.c
parentcrypto: algapi - use common mechanism for inheriting flags (diff)
downloadkernel-2eb27c11937ee9984c04b75d213a737291c5f58c.tar.gz
kernel-2eb27c11937ee9984c04b75d213a737291c5f58c.zip
crypto: algapi - add NEED_FALLBACK to INHERITED_FLAGS
CRYPTO_ALG_NEED_FALLBACK is handled inconsistently. When it's requested to be clear, some templates propagate that request to child algorithms, while others don't. It's apparently desired for NEED_FALLBACK to be propagated, to avoid deadlocks where a module tries to load itself while it's being initialized, and to avoid unnecessarily complex fallback chains where we have e.g. cbc-aes-$driver falling back to cbc(aes-$driver) where aes-$driver itself falls back to aes-generic, instead of cbc-aes-$driver simply falling back to cbc(aes-generic). There have been a number of fixes to this effect: commit 89027579bc6c ("crypto: xts - Propagate NEED_FALLBACK bit") commit d2c2a85cfe82 ("crypto: ctr - Propagate NEED_FALLBACK bit") commit e6c2e65c70a6 ("crypto: cbc - Propagate NEED_FALLBACK bit") But it seems that other templates can have the same problems too. To avoid this whack-a-mole, just add NEED_FALLBACK to INHERITED_FLAGS so that it's always inherited. Signed-off-by: Eric Biggers <[email protected]> Signed-off-by: Herbert Xu <[email protected]>
Diffstat (limited to 'drivers/crypto/inside-secure/safexcel_cipher.c')
0 files changed, 0 insertions, 0 deletions