diff options
| author | Yi Sun <[email protected]> | 2025-07-29 15:03:13 +0000 |
|---|---|---|
| committer | Vinod Koul <[email protected]> | 2025-08-20 17:29:58 +0000 |
| commit | b7cb9a034305d52222433fad10c3de10204f29e7 (patch) | |
| tree | 5191d2a3196d613ed73b5da2e5597eb47bb23ebf /drivers/cdx/controller/mcdi_functions.c | |
| parent | dmaengine: idxd: Remove improper idxd_free (diff) | |
| download | kernel-b7cb9a034305d52222433fad10c3de10204f29e7.tar.gz kernel-b7cb9a034305d52222433fad10c3de10204f29e7.zip | |
dmaengine: idxd: Fix refcount underflow on module unload
A recent refactor introduced a misplaced put_device() call, resulting in a
reference count underflow during module unload.
There is no need to add additional put_device() calls for idxd groups,
engines, or workqueues. Although the commit claims: "Note, this also
fixes the missing put_device() for idxd groups, engines, and wqs."
It appears no such omission actually existed. The required cleanup is
already handled by the call chain:
idxd_unregister_devices() -> device_unregister() -> put_device()
Extend idxd_cleanup() to handle the remaining necessary cleanup and
remove idxd_cleanup_internals(), which duplicates deallocation logic
for idxd, engines, groups, and workqueues. Memory management is also
properly handled through the Linux device model.
Fixes: a409e919ca32 ("dmaengine: idxd: Refactor remove call with idxd_cleanup() helper")
Signed-off-by: Yi Sun <[email protected]>
Tested-by: Shuai Xue <[email protected]>
Reviewed-by: Dave Jiang <[email protected]>
Acked-by: Vinicius Costa Gomes <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Vinod Koul <[email protected]>
Diffstat (limited to 'drivers/cdx/controller/mcdi_functions.c')
0 files changed, 0 insertions, 0 deletions
