diff options
| author | Zijun Hu <[email protected]> | 2024-07-02 14:51:51 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2024-07-04 10:34:50 +0000 |
| commit | bd50a974097bb82d52a458bd3ee39fb723129a0c (patch) | |
| tree | ff3ae3b73b4ba1ee398a968a373d64d47faf3960 /drivers/base/devres.c | |
| parent | devres: Fix devm_krealloc() wasting memory (diff) | |
| download | kernel-bd50a974097bb82d52a458bd3ee39fb723129a0c.tar.gz kernel-bd50a974097bb82d52a458bd3ee39fb723129a0c.zip | |
devres: Fix memory leakage caused by driver API devm_free_percpu()
It will cause memory leakage when use driver API devm_free_percpu()
to free memory allocated by devm_alloc_percpu(), fixed by using
devres_release() instead of devres_destroy() within devm_free_percpu().
Fixes: ff86aae3b411 ("devres: add devm_alloc_percpu()")
Cc: [email protected]
Signed-off-by: Zijun Hu <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'drivers/base/devres.c')
| -rw-r--r-- | drivers/base/devres.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/base/devres.c b/drivers/base/devres.c index ff2247eec43c..8d709dbd4e0c 100644 --- a/drivers/base/devres.c +++ b/drivers/base/devres.c @@ -1225,7 +1225,11 @@ EXPORT_SYMBOL_GPL(__devm_alloc_percpu); */ void devm_free_percpu(struct device *dev, void __percpu *pdata) { - WARN_ON(devres_destroy(dev, devm_percpu_release, devm_percpu_match, + /* + * Use devres_release() to prevent memory leakage as + * devm_free_pages() does. + */ + WARN_ON(devres_release(dev, devm_percpu_release, devm_percpu_match, (__force void *)pdata)); } EXPORT_SYMBOL_GPL(devm_free_percpu); |