diff options
| author | Maurizio Lombardi <[email protected]> | 2024-10-15 11:21:00 +0000 |
|---|---|---|
| committer | Keith Busch <[email protected]> | 2024-10-17 16:55:22 +0000 |
| commit | 26bc0a81f64ce00fc4342c38eeb2eddaad084dd2 (patch) | |
| tree | 0be152e82a7802d9a49bfda24fd9c2a1799b0cc2 /drivers/acpi/cppc_acpi.c | |
| parent | nvme-multipath: defer partition scanning (diff) | |
| download | kernel-26bc0a81f64ce00fc4342c38eeb2eddaad084dd2.tar.gz kernel-26bc0a81f64ce00fc4342c38eeb2eddaad084dd2.zip | |
nvme-pci: fix race condition between reset and nvme_dev_disable()
nvme_dev_disable() modifies the dev->online_queues field, therefore
nvme_pci_update_nr_queues() should avoid racing against it, otherwise
we could end up passing invalid values to blk_mq_update_nr_hw_queues().
WARNING: CPU: 39 PID: 61303 at drivers/pci/msi/api.c:347
pci_irq_get_affinity+0x187/0x210
Workqueue: nvme-reset-wq nvme_reset_work [nvme]
RIP: 0010:pci_irq_get_affinity+0x187/0x210
Call Trace:
<TASK>
? blk_mq_pci_map_queues+0x87/0x3c0
? pci_irq_get_affinity+0x187/0x210
blk_mq_pci_map_queues+0x87/0x3c0
nvme_pci_map_queues+0x189/0x460 [nvme]
blk_mq_update_nr_hw_queues+0x2a/0x40
nvme_reset_work+0x1be/0x2a0 [nvme]
Fix the bug by locking the shutdown_lock mutex before using
dev->online_queues. Give up if nvme_dev_disable() is running or if
it has been executed already.
Fixes: 949928c1c731 ("NVMe: Fix possible queue use after freed")
Tested-by: Yi Zhang <[email protected]>
Reviewed-by: Christoph Hellwig <[email protected]>
Signed-off-by: Maurizio Lombardi <[email protected]>
Signed-off-by: Keith Busch <[email protected]>
Diffstat (limited to 'drivers/acpi/cppc_acpi.c')
0 files changed, 0 insertions, 0 deletions