diff options
| author | Akihiko Odaki <[email protected]> | 2025-03-15 09:12:10 +0000 |
|---|---|---|
| committer | Oliver Upton <[email protected]> | 2025-03-17 17:42:22 +0000 |
| commit | f2aeb7bbd5745fbcf7f0769e29a184e24924b9a9 (patch) | |
| tree | 807834982e2951de083dd1da88e195840f8ab493 /arch/arm64/kvm/emulate-nested.c | |
| parent | Linux 6.14-rc5 (diff) | |
| download | kernel-f2aeb7bbd5745fbcf7f0769e29a184e24924b9a9.tar.gz kernel-f2aeb7bbd5745fbcf7f0769e29a184e24924b9a9.zip | |
KVM: arm64: PMU: Set raw values from user to PM{C,I}NTEN{SET,CLR}, PMOVS{SET,CLR}
Commit a45f41d754e0 ("KVM: arm64: Add {get,set}_user for
PM{C,I}NTEN{SET,CLR}, PMOVS{SET,CLR}") changed KVM_SET_ONE_REG to update
the mentioned registers in a way matching with the behavior of guest
register writes. This is a breaking change of a UAPI though the new
semantics looks cleaner and VMMs are not prepared for this.
Firecracker, QEMU, and crosvm perform migration by listing registers
with KVM_GET_REG_LIST, getting their values with KVM_GET_ONE_REG and
setting them with KVM_SET_ONE_REG. This algorithm assumes
KVM_SET_ONE_REG restores the values retrieved with KVM_GET_ONE_REG
without any alteration. However, bit operations added by the earlier
commit do not preserve the values retried with KVM_GET_ONE_REG and
potentially break migration.
Remove the bit operations that alter the values retrieved with
KVM_GET_ONE_REG.
Cc: [email protected]
Fixes: a45f41d754e0 ("KVM: arm64: Add {get,set}_user for PM{C,I}NTEN{SET,CLR}, PMOVS{SET,CLR}")
Signed-off-by: Akihiko Odaki <[email protected]>
Acked-by: Marc Zyngier <[email protected]>
Reviewed-by: Marc Zyngier <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Oliver Upton <[email protected]>
Diffstat (limited to 'arch/arm64/kvm/emulate-nested.c')
0 files changed, 0 insertions, 0 deletions
