diff options
| author | Julien Brunel <[email protected]> | 2008-10-16 05:04:12 +0000 |
|---|---|---|
| committer | Linus Torvalds <[email protected]> | 2008-10-16 18:21:46 +0000 |
| commit | 67b172c097177835fbf5b0666885c4059a4f67ff (patch) | |
| tree | 2885ade2f6f3fdaae986f4724390adc404c42a2f /Documentation/DocBook/procfs_example.c | |
| parent | reiserfs/procfs.c: remove CVS keywords (diff) | |
| download | kernel-67b172c097177835fbf5b0666885c4059a4f67ff.tar.gz kernel-67b172c097177835fbf5b0666885c4059a4f67ff.zip | |
fs/reiserfs: use an IS_ERR test rather than a NULL test
In case of error, the function open_xa_dir returns an ERR pointer, but
never returns a NULL pointer. So a NULL test that comes after an IS_ERR
test should be deleted.
The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@match_bad_null_test@
expression x, E;
statement S1,S2;
@@
x = open_xa_dir(...)
... when != x = E
(
* if (x == NULL && ...) S1 else S2
|
* if (x == NULL || ...) S1 else S2
)
// </smpl>
Signed-off-by: Julien Brunel <[email protected]>
Signed-off-by: Julia Lawall <[email protected]>
Cc: Jeff Mahoney <[email protected]>
Cc: Jan Kara <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'Documentation/DocBook/procfs_example.c')
0 files changed, 0 insertions, 0 deletions
