diff options
| author | Joe Perches <[email protected]> | 2014-02-21 22:19:30 +0000 |
|---|---|---|
| committer | James Morris <[email protected]> | 2014-02-24 03:44:53 +0000 |
| commit | f5645d3575fe9a2c468889146e152f11c199826e (patch) | |
| tree | 2bbc3b5a28917cf9f9e68155d47d8668f3b1ab18 | |
| parent | security: cleanup Makefiles to use standard syntax for specifying sub-directo... (diff) | |
| download | kernel-f5645d3575fe9a2c468889146e152f11c199826e.tar.gz kernel-f5645d3575fe9a2c468889146e152f11c199826e.zip | |
capability: Use current logging styles
Prefix logging output with "capability: " via pr_fmt.
Convert printks to pr_<level>.
Use pr_<level>_once instead of guard flags.
Coalesce formats.
Signed-off-by: Joe Perches <[email protected]>
Acked-by: Serge E. Hallyn <[email protected]>
Signed-off-by: James Morris <[email protected]>
| -rw-r--r-- | kernel/capability.c | 27 |
1 files changed, 9 insertions, 18 deletions
diff --git a/kernel/capability.c b/kernel/capability.c index 4e66bf9275b0..d6a6c91863ff 100644 --- a/kernel/capability.c +++ b/kernel/capability.c @@ -7,6 +7,8 @@ * 30 May 2002: Cleanup, Robert M. Love <[email protected]> */ +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + #include <linux/audit.h> #include <linux/capability.h> #include <linux/mm.h> @@ -42,15 +44,10 @@ __setup("no_file_caps", file_caps_disable); static void warn_legacy_capability_use(void) { - static int warned; - if (!warned) { - char name[sizeof(current->comm)]; + char name[sizeof(current->comm)]; - printk(KERN_INFO "warning: `%s' uses 32-bit capabilities" - " (legacy support in use)\n", - get_task_comm(name, current)); - warned = 1; - } + pr_info_once("warning: `%s' uses 32-bit capabilities (legacy support in use)\n", + get_task_comm(name, current)); } /* @@ -71,16 +68,10 @@ static void warn_legacy_capability_use(void) static void warn_deprecated_v2(void) { - static int warned; + char name[sizeof(current->comm)]; - if (!warned) { - char name[sizeof(current->comm)]; - - printk(KERN_INFO "warning: `%s' uses deprecated v2" - " capabilities in a way that may be insecure.\n", - get_task_comm(name, current)); - warned = 1; - } + pr_info_once("warning: `%s' uses deprecated v2 capabilities in a way that may be insecure\n", + get_task_comm(name, current)); } /* @@ -380,7 +371,7 @@ bool has_capability_noaudit(struct task_struct *t, int cap) bool ns_capable(struct user_namespace *ns, int cap) { if (unlikely(!cap_valid(cap))) { - printk(KERN_CRIT "capable() called with invalid cap=%u\n", cap); + pr_crit("capable() called with invalid cap=%u\n", cap); BUG(); } |