diff options
| author | Tomi Valkeinen <[email protected]> | 2021-01-18 08:14:46 +0000 |
|---|---|---|
| committer | Mauro Carvalho Chehab <[email protected]> | 2021-02-06 07:38:06 +0000 |
| commit | e88ccf09e79cf33cac40316ba69c820d9eebc82b (patch) | |
| tree | 1cb9fba21c401a1e237f8cfb31cf8716ad3f181c | |
| parent | media: staging/intel-ipu3: Do not zero reserved fields (diff) | |
| download | kernel-e88ccf09e79cf33cac40316ba69c820d9eebc82b.tar.gz kernel-e88ccf09e79cf33cac40316ba69c820d9eebc82b.zip | |
media: i2c: max9286: fix access to unallocated memory
The asd allocated with v4l2_async_notifier_add_fwnode_subdev() must be
of size max9286_asd, otherwise access to max9286_asd->source will go to
unallocated memory.
Fixes: 86d37bf31af6 ("media: i2c: max9286: Allocate v4l2_async_subdev dynamically")
Signed-off-by: Tomi Valkeinen <[email protected]>
Cc: [email protected] # v5.10+
Reviewed-by: Laurent Pinchart <[email protected]>
Reviewed-by: Kieran Bingham <[email protected]>
Tested-by: Kieran Bingham <[email protected]>
Signed-off-by: Sakari Ailus <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
| -rw-r--r-- | drivers/media/i2c/max9286.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c index c82c1493e099..b1e2476d3c9e 100644 --- a/drivers/media/i2c/max9286.c +++ b/drivers/media/i2c/max9286.c @@ -580,7 +580,7 @@ static int max9286_v4l2_notifier_register(struct max9286_priv *priv) asd = v4l2_async_notifier_add_fwnode_subdev(&priv->notifier, source->fwnode, - sizeof(*asd)); + sizeof(struct max9286_asd)); if (IS_ERR(asd)) { dev_err(dev, "Failed to add subdev for source %u: %ld", i, PTR_ERR(asd)); |