diff options
| author | Jakub Kicinski <[email protected]> | 2025-04-29 15:46:55 +0000 |
|---|---|---|
| committer | Paolo Abeni <[email protected]> | 2025-05-02 10:41:02 +0000 |
| commit | d12a7be02524a6f4d8d5d57920001ea63a93f28d (patch) | |
| tree | f88b7dcff40451509e6efa65753f959be4d25e68 | |
| parent | tools: ynl-gen: factor out free_needs_iter for a struct (diff) | |
| download | kernel-d12a7be02524a6f4d8d5d57920001ea63a93f28d.tar.gz kernel-d12a7be02524a6f4d8d5d57920001ea63a93f28d.zip | |
tools: ynl-gen: fill in missing empty attr lists
The C codegen refers to op attribute lists all over the place,
without checking if they are present, even tho attribute list
is technically an optional property. Add them automatically
at init if missing so that we don't have to make specs longer.
Reviewed-by: Donald Hunter <[email protected]>
Reviewed-by: Jacob Keller <[email protected]>
Signed-off-by: Jakub Kicinski <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Paolo Abeni <[email protected]>
| -rwxr-xr-x | tools/net/ynl/pyynl/ynl_gen_c.py | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/tools/net/ynl/pyynl/ynl_gen_c.py b/tools/net/ynl/pyynl/ynl_gen_c.py index 90f7fe6b623b..898c41a7a81f 100755 --- a/tools/net/ynl/pyynl/ynl_gen_c.py +++ b/tools/net/ynl/pyynl/ynl_gen_c.py @@ -938,6 +938,14 @@ class AttrSet(SpecAttrSet): class Operation(SpecOperation): def __init__(self, family, yaml, req_value, rsp_value): + # Fill in missing operation properties (for fixed hdr-only msgs) + for mode in ['do', 'dump', 'event']: + for direction in ['request', 'reply']: + try: + yaml[mode][direction].setdefault('attributes', []) + except KeyError: + pass + super().__init__(family, yaml, req_value, rsp_value) self.render_name = c_lower(family.ident_name + '_' + self.name) |