diff options
| author | Jeremy Kerr <[email protected]> | 2024-08-16 10:29:17 +0000 |
|---|---|---|
| committer | Jakub Kicinski <[email protected]> | 2024-08-20 00:48:00 +0000 |
| commit | ce335db0621648472f9bb4b7191eb2e13a5793cf (patch) | |
| tree | 250675f1805359beca973da5119ac8f53160eb5c | |
| parent | tcp: prevent concurrent execution of tcp_sk_exit_batch (diff) | |
| download | kernel-ce335db0621648472f9bb4b7191eb2e13a5793cf.tar.gz kernel-ce335db0621648472f9bb4b7191eb2e13a5793cf.zip | |
net: mctp: test: Use correct skb for route input check
In the MCTP route input test, we're routing one skb, then (when delivery
is expected) checking the resulting routed skb.
However, we're currently checking the original skb length, rather than
the routed skb. Check the routed skb instead; the original will have
been freed at this point.
Fixes: 8892c0490779 ("mctp: Add route input to socket tests")
Reported-by: Dan Carpenter <[email protected]>
Closes: https://lore.kernel.org/kernel-janitors/[email protected]/
Signed-off-by: Jeremy Kerr <[email protected]>
Reviewed-by: Simon Horman <[email protected]>
Link: https://patch.msgid.link/20240816-mctp-kunit-skb-fix-v1-1-3c367ac89c27@codeconstruct.com.au
Signed-off-by: Jakub Kicinski <[email protected]>
| -rw-r--r-- | net/mctp/test/route-test.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/mctp/test/route-test.c b/net/mctp/test/route-test.c index 77e5dd422258..8551dab1d1e6 100644 --- a/net/mctp/test/route-test.c +++ b/net/mctp/test/route-test.c @@ -366,7 +366,7 @@ static void mctp_test_route_input_sk(struct kunit *test) skb2 = skb_recv_datagram(sock->sk, MSG_DONTWAIT, &rc); KUNIT_EXPECT_NOT_ERR_OR_NULL(test, skb2); - KUNIT_EXPECT_EQ(test, skb->len, 1); + KUNIT_EXPECT_EQ(test, skb2->len, 1); skb_free_datagram(sock->sk, skb2); |