diff options
| author | Miaoqian Lin <[email protected]> | 2022-12-29 07:25:33 +0000 |
|---|---|---|
| committer | Hans de Goede <[email protected]> | 2023-01-12 19:04:38 +0000 |
| commit | ccb32e2be14271a60e9ba89c6d5660cc9998773c (patch) | |
| tree | 256620d7c17091b6190c6b06b1da074426f1ba86 | |
| parent | platform/x86: intel/pmc/core: Add Meteor Lake mobile support (diff) | |
| download | kernel-ccb32e2be14271a60e9ba89c6d5660cc9998773c.tar.gz kernel-ccb32e2be14271a60e9ba89c6d5660cc9998773c.zip | |
platform/x86/amd: Fix refcount leak in amd_pmc_probe
pci_get_domain_bus_and_slot() takes reference, the caller should release
the reference by calling pci_dev_put() after use. Call pci_dev_put() in
the error path to fix this.
Fixes: 3d7d407dfb05 ("platform/x86: amd-pmc: Add support for AMD Spill to DRAM STB feature")
Signed-off-by: Miaoqian Lin <[email protected]>
Reviewed-by: Mario Limonciello <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Reviewed-by: Hans de Goede <[email protected]>
Signed-off-by: Hans de Goede <[email protected]>
| -rw-r--r-- | drivers/platform/x86/amd/pmc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/platform/x86/amd/pmc.c b/drivers/platform/x86/amd/pmc.c index 439d282aafd1..8d924986381b 100644 --- a/drivers/platform/x86/amd/pmc.c +++ b/drivers/platform/x86/amd/pmc.c @@ -932,7 +932,7 @@ static int amd_pmc_probe(struct platform_device *pdev) if (enable_stb && (dev->cpu_id == AMD_CPU_ID_YC || dev->cpu_id == AMD_CPU_ID_CB)) { err = amd_pmc_s2d_init(dev); if (err) - return err; + goto err_pci_dev_put; } platform_set_drvdata(pdev, dev); |