diff options
| author | Dinghao Liu <[email protected]> | 2023-11-23 07:33:22 +0000 |
|---|---|---|
| committer | Alex Deucher <[email protected]> | 2023-11-29 21:49:22 +0000 |
| commit | b0e5c88d8a88bdcc9834409387e10a5ae1b2753e (patch) | |
| tree | c94dd2c12659a8c5364f559ab8bd2d4db1c202f2 | |
| parent | drm/amdgpu: fix AGP addressing when GART is not at 0 (diff) | |
| download | kernel-b0e5c88d8a88bdcc9834409387e10a5ae1b2753e.tar.gz kernel-b0e5c88d8a88bdcc9834409387e10a5ae1b2753e.zip | |
drm/amd/pm: fix a memleak in aldebaran_tables_init
When kzalloc() for smu_table->ecc_table fails, we should free
the previously allocated resources to prevent memleak.
Fixes: edd794208555 ("drm/amd/pm: add message smu to get ecc_table v2")
Signed-off-by: Dinghao Liu <[email protected]>
Signed-off-by: Alex Deucher <[email protected]>
| -rw-r--r-- | drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c index 1a6675d70a4b..f1440869d1ce 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c @@ -257,8 +257,11 @@ static int aldebaran_tables_init(struct smu_context *smu) } smu_table->ecc_table = kzalloc(tables[SMU_TABLE_ECCINFO].size, GFP_KERNEL); - if (!smu_table->ecc_table) + if (!smu_table->ecc_table) { + kfree(smu_table->metrics_table); + kfree(smu_table->gpu_metrics_table); return -ENOMEM; + } return 0; } |