aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKees Cook <[email protected]>2013-09-11 04:39:11 +0000
committerDavid S. Miller <[email protected]>2013-09-12 21:20:03 +0000
commita9677bc024dcaafcf36c1cc4b0706b87be26ee5f (patch)
tree08a4d696b5cf98229207fa19fc3cea11f70d0a74
parentnetpoll: Should handle ETH_P_ARP other than ETH_P_IP in netpoll_neigh_reply (diff)
downloadkernel-a9677bc024dcaafcf36c1cc4b0706b87be26ee5f.tar.gz
kernel-a9677bc024dcaafcf36c1cc4b0706b87be26ee5f.zip
xen-netback: fix possible format string flaw
This makes sure a format string cannot accidentally leak into the kthread_run() call. Signed-off-by: Kees Cook <[email protected]> Acked-by: Ian Campbell <[email protected]> Signed-off-by: David S. Miller <[email protected]>
-rw-r--r--drivers/net/xen-netback/interface.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index 625c6f49cfba..77fee1d51fb2 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -406,7 +406,7 @@ int xenvif_connect(struct xenvif *vif, unsigned long tx_ring_ref,
init_waitqueue_head(&vif->wq);
vif->task = kthread_create(xenvif_kthread,
- (void *)vif, vif->dev->name);
+ (void *)vif, "%s", vif->dev->name);
if (IS_ERR(vif->task)) {
pr_warn("Could not allocate kthread for %s\n", vif->dev->name);
err = PTR_ERR(vif->task);