diff options
| author | Ma Ke <[email protected]> | 2025-09-30 08:16:18 +0000 |
|---|---|---|
| committer | Rob Herring (Arm) <[email protected]> | 2025-10-01 14:33:23 +0000 |
| commit | a8de554774ae48efbe48ace79f8badae2daa2bf1 (patch) | |
| tree | 341d1eb856c7c311beefdec05914b05da5de5637 | |
| parent | of: doc: Fix typo in doc comments. (diff) | |
| download | kernel-a8de554774ae48efbe48ace79f8badae2daa2bf1.tar.gz kernel-a8de554774ae48efbe48ace79f8badae2daa2bf1.zip | |
of: unittest: Fix device reference count leak in of_unittest_pci_node_verify
In of_unittest_pci_node_verify(), when the add parameter is false,
device_find_any_child() obtains a reference to a child device. This
function implicitly calls get_device() to increment the device's
reference count before returning the pointer. However, the caller
fails to properly release this reference by calling put_device(),
leading to a device reference count leak. Add put_device() in the else
branch immediately after child_dev is no longer needed.
As the comment of device_find_any_child states: "NOTE: you will need
to drop the reference with put_device() after use".
Found by code review.
Cc: [email protected]
Fixes: 26409dd04589 ("of: unittest: Add pci_dt_testdrv pci driver")
Signed-off-by: Ma Ke <[email protected]>
Signed-off-by: Rob Herring (Arm) <[email protected]>
| -rw-r--r-- | drivers/of/unittest.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index e3503ec20f6c..388e9ec2cccf 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -4300,6 +4300,7 @@ static int of_unittest_pci_node_verify(struct pci_dev *pdev, bool add) unittest(!np, "Child device tree node is not removed\n"); child_dev = device_find_any_child(&pdev->dev); unittest(!child_dev, "Child device is not removed\n"); + put_device(child_dev); } failed: |