diff options
| author | Boris Ostrovsky <[email protected]> | 2020-01-28 15:31:26 +0000 |
|---|---|---|
| committer | Boris Ostrovsky <[email protected]> | 2020-01-28 18:22:48 +0000 |
| commit | 9293724192a73f49c722e9685d45649c6df67dfe (patch) | |
| tree | eedc228247491ab7cfc18143003803181475f5e6 | |
| parent | xen/balloon: Support xend-based toolstack take two (diff) | |
| download | kernel-9293724192a73f49c722e9685d45649c6df67dfe.tar.gz kernel-9293724192a73f49c722e9685d45649c6df67dfe.zip | |
xen/gntdev: Do not use mm notifiers with autotranslating guests
Commit d3eeb1d77c5d ("xen/gntdev: use mmu_interval_notifier_insert")
missed a test for use_ptemod when calling mmu_interval_read_begin(). Fix
that.
Fixes: d3eeb1d77c5d ("xen/gntdev: use mmu_interval_notifier_insert")
CC: [email protected] # 5.5
Reported-by: Ilpo Järvinen <[email protected]>
Tested-by: Ilpo Järvinen <[email protected]>
Signed-off-by: Boris Ostrovsky <[email protected]>
Reviewed-by: Jason Gunthorpe <[email protected]>
Acked-by: Juergen Gross <[email protected]>
| -rw-r--r-- | drivers/xen/gntdev.c | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index 4fc83e3f5ad3..0258415ca0b2 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -1006,19 +1006,19 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma) } mutex_unlock(&priv->lock); - /* - * gntdev takes the address of the PTE in find_grant_ptes() and passes - * it to the hypervisor in gntdev_map_grant_pages(). The purpose of - * the notifier is to prevent the hypervisor pointer to the PTE from - * going stale. - * - * Since this vma's mappings can't be touched without the mmap_sem, - * and we are holding it now, there is no need for the notifier_range - * locking pattern. - */ - mmu_interval_read_begin(&map->notifier); - if (use_ptemod) { + /* + * gntdev takes the address of the PTE in find_grant_ptes() and + * passes it to the hypervisor in gntdev_map_grant_pages(). The + * purpose of the notifier is to prevent the hypervisor pointer + * to the PTE from going stale. + * + * Since this vma's mappings can't be touched without the + * mmap_sem, and we are holding it now, there is no need for + * the notifier_range locking pattern. + */ + mmu_interval_read_begin(&map->notifier); + map->pages_vm_start = vma->vm_start; err = apply_to_page_range(vma->vm_mm, vma->vm_start, vma->vm_end - vma->vm_start, |