diff options
| author | Uwe Kleine-König <[email protected]> | 2023-03-15 15:05:40 +0000 |
|---|---|---|
| committer | Mark Brown <[email protected]> | 2023-03-20 13:07:42 +0000 |
| commit | 8756b2ecbd2aa22d6981f6a48a804f0d2cec68a8 (patch) | |
| tree | f42b70afb8b3a7f00853ccaa4ea25c4bbc97d07f | |
| parent | ASoC: codecs: cs47l92: Convert to platform remove callback returning void (diff) | |
| download | kernel-8756b2ecbd2aa22d6981f6a48a804f0d2cec68a8.tar.gz kernel-8756b2ecbd2aa22d6981f6a48a804f0d2cec68a8.zip | |
ASoC: codecs: inno_rk3036: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <[email protected]>
Acked-by: Takashi Iwai <[email protected]>
Acked-by: Nicolas Ferre <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
| -rw-r--r-- | sound/soc/codecs/inno_rk3036.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/sound/soc/codecs/inno_rk3036.c b/sound/soc/codecs/inno_rk3036.c index 8222cde6e3b9..11320423c69c 100644 --- a/sound/soc/codecs/inno_rk3036.c +++ b/sound/soc/codecs/inno_rk3036.c @@ -457,13 +457,11 @@ static int rk3036_codec_platform_probe(struct platform_device *pdev) return ret; } -static int rk3036_codec_platform_remove(struct platform_device *pdev) +static void rk3036_codec_platform_remove(struct platform_device *pdev) { struct rk3036_codec_priv *priv = dev_get_drvdata(&pdev->dev); clk_disable_unprepare(priv->pclk); - - return 0; } static const struct of_device_id rk3036_codec_of_match[] __maybe_unused = { @@ -478,7 +476,7 @@ static struct platform_driver rk3036_codec_platform_driver = { .of_match_table = of_match_ptr(rk3036_codec_of_match), }, .probe = rk3036_codec_platform_probe, - .remove = rk3036_codec_platform_remove, + .remove_new = rk3036_codec_platform_remove, }; module_platform_driver(rk3036_codec_platform_driver); |