diff options
| author | Srinivas Neeli <[email protected]> | 2021-01-29 14:26:46 +0000 |
|---|---|---|
| committer | Bartosz Golaszewski <[email protected]> | 2021-02-15 10:43:33 +0000 |
| commit | 45c5277f347841daefb1a7b48da9904ef9b46ca9 (patch) | |
| tree | 1781d410d2b9739a2b642c2fc8ff9bb2592b13dc | |
| parent | gpio: msic: Drop driver from Makefile (diff) | |
| download | kernel-45c5277f347841daefb1a7b48da9904ef9b46ca9.tar.gz kernel-45c5277f347841daefb1a7b48da9904ef9b46ca9.zip | |
gpio: gpio-xilinx: Simplify with dev_err_probe()
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.
Signed-off-by: Srinivas Neeli <[email protected]>
Reviewed-by: Linus Walleij <[email protected]>
Signed-off-by: Bartosz Golaszewski <[email protected]>
| -rw-r--r-- | drivers/gpio/gpio-xilinx.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c index be539381fd82..d010a63d5d15 100644 --- a/drivers/gpio/gpio-xilinx.c +++ b/drivers/gpio/gpio-xilinx.c @@ -357,11 +357,8 @@ static int xgpio_probe(struct platform_device *pdev) } chip->clk = devm_clk_get_optional(&pdev->dev, NULL); - if (IS_ERR(chip->clk)) { - if (PTR_ERR(chip->clk) != -EPROBE_DEFER) - dev_dbg(&pdev->dev, "Input clock not found\n"); - return PTR_ERR(chip->clk); - } + if (IS_ERR(chip->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(chip->clk), "input clock not found.\n"); status = clk_prepare_enable(chip->clk); if (status < 0) { |