diff options
| author | Masami Hiramatsu (Google) <[email protected]> | 2025-01-09 14:29:37 +0000 |
|---|---|---|
| committer | Masami Hiramatsu (Google) <[email protected]> | 2025-01-09 23:57:18 +0000 |
| commit | 30c8fd31c571db486a5331a92d03eb60a0fb277c (patch) | |
| tree | 2c2cd5279b9cc98af7809d10103a1654c080e332 | |
| parent | Linux 6.13-rc6 (diff) | |
| download | kernel-30c8fd31c571db486a5331a92d03eb60a0fb277c.tar.gz kernel-30c8fd31c571db486a5331a92d03eb60a0fb277c.zip | |
tracing/kprobes: Fix to free objects when failed to copy a symbol
In __trace_kprobe_create(), if something fails it must goto error block
to free objects. But when strdup() a symbol, it returns without that.
Fix it to goto the error block to free objects correctly.
Link: https://lore.kernel.org/all/173643297743.1514810.2408159540454241947.stgit@devnote2/
Fixes: 6212dd29683e ("tracing/kprobes: Use dyn_event framework for kprobe events")
Signed-off-by: Masami Hiramatsu (Google) <[email protected]>
Reviewed-by: Steven Rostedt (Google) <[email protected]>
| -rw-r--r-- | kernel/trace/trace_kprobe.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c index 935a886af40c..0642ea174849 100644 --- a/kernel/trace/trace_kprobe.c +++ b/kernel/trace/trace_kprobe.c @@ -940,8 +940,10 @@ static int __trace_kprobe_create(int argc, const char *argv[]) } /* a symbol specified */ symbol = kstrdup(argv[1], GFP_KERNEL); - if (!symbol) - return -ENOMEM; + if (!symbol) { + ret = -ENOMEM; + goto error; + } tmp = strchr(symbol, '%'); if (tmp) { |