diff options
| author | Jiapeng Chong <[email protected]> | 2021-06-02 10:05:48 +0000 |
|---|---|---|
| committer | Hans de Goede <[email protected]> | 2021-06-16 15:47:51 +0000 |
| commit | 28e367127718a9cb85d615a71e152f7acee41bfc (patch) | |
| tree | 4da6424a24d69bed5d68002ca6e5044cf8c94b46 | |
| parent | platform/x86: touchscreen_dmi: Fix Chuwi Hi10 Pro comment (diff) | |
| download | kernel-28e367127718a9cb85d615a71e152f7acee41bfc.tar.gz kernel-28e367127718a9cb85d615a71e152f7acee41bfc.zip | |
platform/x86: toshiba_acpi: Fix missing error code in toshiba_acpi_setup_keyboard()
The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'error'.
Eliminate the follow smatch warning:
drivers/platform/x86/toshiba_acpi.c:2834 toshiba_acpi_setup_keyboard()
warn: missing error code 'error'.
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
Link: https://lore.kernel.org/r/1622628348-87035-1-git-send-email-jiapeng.chong@linux.alibaba.com
Signed-off-by: Hans de Goede <[email protected]>
| -rw-r--r-- | drivers/platform/x86/toshiba_acpi.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index fa7232ad8c39..352508d30467 100644 --- a/drivers/platform/x86/toshiba_acpi.c +++ b/drivers/platform/x86/toshiba_acpi.c @@ -2831,6 +2831,7 @@ static int toshiba_acpi_setup_keyboard(struct toshiba_acpi_dev *dev) if (!dev->info_supported && !dev->system_event_supported) { pr_warn("No hotkey query interface found\n"); + error = -EINVAL; goto err_remove_filter; } |