diff options
| author | Alex Deucher <[email protected]> | 2020-06-17 18:52:07 +0000 |
|---|---|---|
| committer | Alex Deucher <[email protected]> | 2020-07-01 05:59:23 +0000 |
| commit | 1c1ada37af6ee6fb9cfc8da6a56cc83208cd8d6f (patch) | |
| tree | 61daa1e60b903b219a97ca8520c6c37a9e268a71 | |
| parent | drm/amdgpu/fence: fix ref count leak when pm_runtime_get_sync fails (diff) | |
| download | kernel-1c1ada37af6ee6fb9cfc8da6a56cc83208cd8d6f.tar.gz kernel-1c1ada37af6ee6fb9cfc8da6a56cc83208cd8d6f.zip | |
drm/amdkfd: fix ref count leak when pm_runtime_get_sync fails
The call to pm_runtime_get_sync increments the counter even in case of
failure, leading to incorrect ref count.
In case of failure, decrement the ref count before returning.
Reviewed-by: Rajneesh Bhardwaj <[email protected]>
Signed-off-by: Alex Deucher <[email protected]>
| -rw-r--r-- | drivers/gpu/drm/amd/amdkfd/kfd_process.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c index a9a7f5aa2710..0b4f40905f55 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c @@ -1116,8 +1116,10 @@ struct kfd_process_device *kfd_bind_process_to_device(struct kfd_dev *dev, */ if (!pdd->runtime_inuse) { err = pm_runtime_get_sync(dev->ddev->dev); - if (err < 0) + if (err < 0) { + pm_runtime_put_autosuspend(dev->ddev->dev); return ERR_PTR(err); + } } err = kfd_iommu_bind_process_to_device(pdd); |