diff options
| author | Pan Bian <[email protected]> | 2016-12-03 15:11:42 +0000 |
|---|---|---|
| committer | Sean Paul <[email protected]> | 2016-12-05 18:14:13 +0000 |
| commit | 16571a8a435abf73cde769918850ca76a471f14c (patch) | |
| tree | cf07ae2efb31d8e7dae9684c3727ab6b478a1e7b | |
| parent | drm/qxl: Don't register debugfs for control minors (diff) | |
| download | kernel-16571a8a435abf73cde769918850ca76a471f14c.tar.gz kernel-16571a8a435abf73cde769918850ca76a471f14c.zip | |
drm/qxl: fix use of uninitialized variable
In function qxl_release_alloc(), when kmalloc() returns a NULL pointer,
it returns value 0 and parameter *ret is uninitialized. 0 means no error
to the callers of qxl_release_alloc(). The callers keep going and will
try to reference the uninitialized variable. This patch fixes the bug,
returning "-ENOMEM" when kmalloc() fails.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188911
Signed-off-by: Pan Bian <[email protected]>
[seanpaul fixed up subject prefix]
Signed-off-by: Sean Paul <[email protected]>
Link: http://patchwork.freedesktop.org/patch/msgid/[email protected]
| -rw-r--r-- | drivers/gpu/drm/qxl/qxl_release.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/qxl/qxl_release.c b/drivers/gpu/drm/qxl/qxl_release.c index 50b4e522f05f..e6ec845b5be0 100644 --- a/drivers/gpu/drm/qxl/qxl_release.c +++ b/drivers/gpu/drm/qxl/qxl_release.c @@ -134,7 +134,7 @@ qxl_release_alloc(struct qxl_device *qdev, int type, release = kmalloc(size, GFP_KERNEL); if (!release) { DRM_ERROR("Out of memory\n"); - return 0; + return -ENOMEM; } release->base.ops = NULL; release->type = type; |