diff options
| author | Pavel Begunkov <[email protected]> | 2025-07-14 10:57:23 +0000 |
|---|---|---|
| committer | Jens Axboe <[email protected]> | 2025-07-14 14:54:43 +0000 |
| commit | 08ca1409c4fa37ec93de08b9963390ed68a5ae8c (patch) | |
| tree | d6cce797c035c73155d00ec0b8b33c0fa26a7449 | |
| parent | Revert "io_uring: gate REQ_F_ISREG on !S_ANON_INODE as well" (diff) | |
| download | kernel-08ca1409c4fa37ec93de08b9963390ed68a5ae8c.tar.gz kernel-08ca1409c4fa37ec93de08b9963390ed68a5ae8c.zip | |
io_uring/zcrx: disallow user selected dmabuf offset and size
zcrx shouldn't be so frivolous about cutting a dmabuf sgtable and taking
a subrange into it, the dmabuf layer might be not expecting that. It
shouldn't be a problem for now, but since the zcrx dmabuf support is new
and there shouldn't be any real users, let's play safe and reject user
provided ranges into dmabufs. Also, it shouldn't be needed as userspace
should size them appropriately.
Fixes: a5c98e9424573 ("io_uring/zcrx: dmabuf backed zerocopy receive")
Signed-off-by: Pavel Begunkov <[email protected]>
Link: https://lore.kernel.org/r/be899f1afed32053eb2e2079d0da241514674aca.1752443579.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <[email protected]>
| -rw-r--r-- | io_uring/zcrx.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/io_uring/zcrx.c b/io_uring/zcrx.c index 67c518d22e0c..e3eef4ee4454 100644 --- a/io_uring/zcrx.c +++ b/io_uring/zcrx.c @@ -76,6 +76,8 @@ static int io_import_dmabuf(struct io_zcrx_ifq *ifq, int dmabuf_fd = area_reg->dmabuf_fd; int i, ret; + if (off) + return -EINVAL; if (WARN_ON_ONCE(!ifq->dev)) return -EFAULT; if (!IS_ENABLED(CONFIG_DMA_SHARED_BUFFER)) @@ -106,7 +108,7 @@ static int io_import_dmabuf(struct io_zcrx_ifq *ifq, for_each_sgtable_dma_sg(mem->sgt, sg, i) total_size += sg_dma_len(sg); - if (total_size < off + len) { + if (total_size != len) { ret = -EINVAL; goto err; } |