diff options
| author | Andrzej Hajda <[email protected]> | 2015-09-21 13:34:08 +0000 |
|---|---|---|
| committer | Ralf Baechle <[email protected]> | 2015-10-26 08:49:39 +0000 |
| commit | 05513992c69d159e698bb4b5f651abd0ceff525c (patch) | |
| tree | f3a1f07ae8f13cc29f2fac3b4a4f86e2c093b02e | |
| parent | Linux 4.3-rc7 (diff) | |
| download | kernel-05513992c69d159e698bb4b5f651abd0ceff525c.tar.gz kernel-05513992c69d159e698bb4b5f651abd0ceff525c.zip | |
MIPS: Remove invalid check
Unsigned values cannot be lesser than zero.
The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
[[email protected]: Chris Dearman's original commit
9318c51acd9689505850152cc98277a6d6f2d752 ([MIPS] MIPS32/MIPS64 secondary
cache management) introduced these less than zero checks in 2.6.18.]
[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
Signed-off-by: Andrzej Hajda <[email protected]>
Cc: [email protected]
Cc: Bartlomiej Zolnierkiewicz <[email protected]>
Cc: Marek Szyprowski <[email protected]>
Cc: Markos Chandras <[email protected]>
Cc: Chris Dearman <[email protected]>
Cc: [email protected]
Patchwork: https://patchwork.linux-mips.org/patch/11165/
Signed-off-by: Ralf Baechle <[email protected]>
| -rw-r--r-- | arch/mips/mm/sc-mips.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/mips/mm/sc-mips.c b/arch/mips/mm/sc-mips.c index 53ea8391f9bb..1755187a6545 100644 --- a/arch/mips/mm/sc-mips.c +++ b/arch/mips/mm/sc-mips.c @@ -162,13 +162,13 @@ static inline int __init mips_sc_probe(void) return 0; tmp = (config2 >> 8) & 0x0f; - if (0 <= tmp && tmp <= 7) + if (tmp <= 7) c->scache.sets = 64 << tmp; else return 0; tmp = (config2 >> 0) & 0x0f; - if (0 <= tmp && tmp <= 7) + if (tmp <= 7) c->scache.ways = tmp + 1; else return 0; |