js: change the write access for js class methods

--
* src/ [Connection, Error, Key, Keyring, MEssage, Signature, gpgmejs]:
    Functions and values that are not meant to be overwritten are now
    moved into their constructors, thus eliminating the possibility of
    overwrites after initialization.

* Key: The mode of use (synchronous cached, or async promises) ivs now
  determined at initialization of that Key. The property Key.isAsync
  reflects this state.

* unittests: fixed old Key syntax for testing.

* Message.js isComplete is now a method and not a getter anymore.

* Added some startup tests.

2 files changed, 16 insertions, 24 deletions

diff --git a/lang/js/BrowserTestExtension/tests/inputvalues.js b/lang/js/BrowserTestExtension/tests/inputvalues.js
index 5289eab7..9d956b69 100644
--- a/lang/js/BrowserTestExtension/tests/inputvalues.js
+++ b/lang/js/BrowserTestExtension/tests/inputvalues.js
@@ -86,7 +86,9 @@ const inputvalues = {// eslint-disable-line no-unused-vars
         'T2JfzEN+E7Y3PB8UwLgp/ZRmG8zRrQ==\n' +
         '=ioB6\n' +
         '-----END PGP SIGNATURE-----\n',
-    }
+    },
+
+    someInputParameter: 'bad string'
 };
 
 // (Pseudo-)Random String covering all of utf8.
@@ -158,27 +160,6 @@ function slightlyLessBoringString(megabytes, set){
     return string.join('');
 }
 
-// Take a gpg looking string and destroy it a bit by changing random values
-// eslint-disable-next-line no-unused-vars
-function destroylegitimateGpg(string, mutations=5){
-    const allowed = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz+/\n';
-    for (let i=0; i < mutations.length; i++){
-        // leave the first and last 35 chars (header/footer) intact
-        let position = Math.floor(Math.random() *(string.length - 70)) + 35;
-        let str0 = string.substring(0,position - 1);
-        let str1 = string.substring(position, position + 1);
-        let str2 = string.substring(position +1);
-        let success = false;
-        while (!success){
-            let newchar = Math.floor(Math.random() * allowed.length);
-            if (newchar !== str1){
-                string = str0 + newchar + str2;
-                success = true;
-            }
-        }
-    }
-}
-
 // Data encrypted with testKey
 const encryptedData =// eslint-disable-line no-unused-vars
     '-----BEGIN PGP MESSAGE-----\n' +
diff --git a/lang/js/BrowserTestExtension/tests/startup.js b/lang/js/BrowserTestExtension/tests/startup.js
index dae94025..1e2784d9 100644
--- a/lang/js/BrowserTestExtension/tests/startup.js
+++ b/lang/js/BrowserTestExtension/tests/startup.js
@@ -21,17 +21,28 @@
  *     Maximilian Krambach <[email protected]>
  */
 
-/* global describe, it, expect, Gpgmejs */
+/* global describe, it, expect, Gpgmejs, inputvalues */
 
 describe('GPGME context', function(){
     it('Starting a GpgME instance', function(done){
         let prm = Gpgmejs.init();
+        const input = inputvalues.someInputParameter;
         prm.then(
             function(context){
                 expect(context).to.be.an('object');
                 expect(context.encrypt).to.be.a('function');
                 expect(context.decrypt).to.be.a('function');
+                expect(context.sign).to.be.a('function');
+                expect(context.verify).to.be.a('function');
+                context.Keyring = input;
+                expect(context.Keyring).to.be.an('object');
+                expect(context.Keyring).to.not.equal(input);
+                expect(context._Keyring).to.equal(context.Keyring);
+                expect(context.Keyring.getKeys).to.be.a('function');
+                expect(context.Keyring.getDefaultKey).to.be.a('function');
+                expect(context.Keyring.importKey).to.be.a('function');
+                expect(context.Keyring.generateKey).to.be.a('function');
                 done();
             });
     });
-});
+});
\ No newline at end of file