aboutsummaryrefslogtreecommitdiffstats
path: root/apps
diff options
context:
space:
mode:
authorEugene Syromiatnikov <[email protected]>2026-07-20 19:10:23 +0200
committerEugene Syromiatnikov <[email protected]>2026-08-11 15:56:00 +0200
commit5b05b7da7c8109c8128dee71ce5ed73eb326fc15 (patch)
tree330121a87c4ebfd91b09703fded41b770869f5c7 /apps
parentstatem: add missing SSLfatal in padding extension construction (diff)
downloadopenssl-5b05b7da7c8109c8128dee71ce5ed73eb326fc15.tar.gz
openssl-5b05b7da7c8109c8128dee71ce5ed73eb326fc15.zip
Rename ASN1_STRING_length_ex() to ASN1_STRING_get_length()
To make it in line with ASN1_BIT_STRING_get_length() and other (size) getters. The majority of the changes was done by for i in `git grep -l ASN1_STRING_length_ex`; do \ sed -i 's/ASN1_STRING_length_ex/ASN1_STRING_get_length/g' "$i"; \ done with a manual touch-up in util/libcrypto.num. Complements: 28179061bfcd "Prepare a now opaque ASN1_STRING for the size_t rapture." Signed-off-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Nikola Pajkovsky <[email protected]> Reviewed-by: Bob Beck <[email protected]> Reviewed-by: Simo Sorce <[email protected]> MergeDate: Tue Aug 11 13:56:42 2026 (Merged from https://github.com/openssl/openssl/pull/32015)
Diffstat (limited to 'apps')
-rw-r--r--apps/asn1parse.c2
-rw-r--r--apps/ca.c20
-rw-r--r--apps/cms.c2
-rw-r--r--apps/lib/apps.c4
-rw-r--r--apps/lib/cmp_mock_srv.c2
-rw-r--r--apps/pkcs12.c16
-rw-r--r--apps/s_client.c2
7 files changed, 24 insertions, 24 deletions
diff --git a/apps/asn1parse.c b/apps/asn1parse.c
index b8449762fe7..3f8623edafa 100644
--- a/apps/asn1parse.c
+++ b/apps/asn1parse.c
@@ -273,7 +273,7 @@ int asn1parse_main(int argc, char **argv)
}
/* hmm... this is a little evil but it works */
tmpbuf = ASN1_STRING_get0_data(at->value.asn1_string);
- tmplen = ASN1_STRING_length_ex(at->value.asn1_string);
+ tmplen = ASN1_STRING_get_length(at->value.asn1_string);
if (tmplen > INT_MAX) {
BIO_puts(bio_err, "ASN.1 string length exceeds INT_MAX\n");
ERR_print_errors(bio_err);
diff --git a/apps/ca.c b/apps/ca.c
index c7b5a1c22d5..a25661956b3 100644
--- a/apps/ca.c
+++ b/apps/ca.c
@@ -1080,7 +1080,7 @@ end_of_options:
X509 *xi = sk_X509_value(cert_sk, i);
const ASN1_INTEGER *serialNumber = X509_get0_serialNumber(xi);
const unsigned char *psn = ASN1_STRING_get0_data(serialNumber);
- const size_t snl = ASN1_STRING_length_ex(serialNumber);
+ const size_t snl = ASN1_STRING_get_length(serialNumber);
const size_t filen_len = 2 * (snl > 0 ? snl : 1) + sizeof(".pem");
char *n = new_cert + outdirlen;
@@ -1526,7 +1526,7 @@ static int do_body(X509 **xret, EVP_PKEY *pkey, X509 *x509,
goto end;
}
if (type != V_ASN1_BMPSTRING && type != V_ASN1_UTF8STRING) {
- size_t tmp = ASN1_STRING_length_ex(str);
+ size_t tmp = ASN1_STRING_get_length(str);
if (tmp > INT_MAX)
goto end;
j = ASN1_PRINTABLE_type(ASN1_STRING_get0_data(str), (int)tmp);
@@ -1906,9 +1906,9 @@ static int do_body(X509 **xret, EVP_PKEY *pkey, X509 *x509,
/* We now just add it to the database as DB_TYPE_VAL('V') */
row[DB_type] = OPENSSL_strdup("V");
tm = X509_get0_notAfter(ret);
- row[DB_exp_date] = app_malloc(ASN1_STRING_length_ex(tm) + 1, "row expdate");
- memcpy(row[DB_exp_date], ASN1_STRING_get0_data(tm), ASN1_STRING_length_ex(tm));
- row[DB_exp_date][ASN1_STRING_length_ex(tm)] = '\0';
+ row[DB_exp_date] = app_malloc(ASN1_STRING_get_length(tm) + 1, "row expdate");
+ memcpy(row[DB_exp_date], ASN1_STRING_get0_data(tm), ASN1_STRING_get_length(tm));
+ row[DB_exp_date][ASN1_STRING_get_length(tm)] = '\0';
row[DB_rev_date] = NULL;
row[DB_file] = OPENSSL_strdup("unknown");
if ((row[DB_type] == NULL) || (row[DB_file] == NULL)
@@ -2142,9 +2142,9 @@ static int do_revoke(X509 *x509, CA_DB *db, REVINFO_TYPE rev_type,
/* We now just add it to the database as DB_TYPE_REV('V') */
row[DB_type] = OPENSSL_strdup("V");
tm = X509_get0_notAfter(x509);
- row[DB_exp_date] = app_malloc(ASN1_STRING_length_ex(tm) + 1, "row exp_data");
- memcpy(row[DB_exp_date], ASN1_STRING_get0_data(tm), ASN1_STRING_length_ex(tm));
- row[DB_exp_date][ASN1_STRING_length_ex(tm)] = '\0';
+ row[DB_exp_date] = app_malloc(ASN1_STRING_get_length(tm) + 1, "row exp_data");
+ memcpy(row[DB_exp_date], ASN1_STRING_get0_data(tm), ASN1_STRING_get_length(tm));
+ row[DB_exp_date][ASN1_STRING_get_length(tm)] = '\0';
row[DB_rev_date] = NULL;
row[DB_file] = OPENSSL_strdup("unknown");
@@ -2412,7 +2412,7 @@ static char *make_revocation_str(REVINFO_TYPE rev_type, const char *rev_arg)
if (!revtm)
return NULL;
- i = ASN1_STRING_length_ex(revtm) + 1;
+ i = ASN1_STRING_get_length(revtm) + 1;
if (reason)
i += strlen(reason) + 1;
@@ -2519,7 +2519,7 @@ static int old_entry_print(const ASN1_OBJECT *obj, const ASN1_STRING *str)
BIO_printf(bio_err, "ASN.1 %2d:'", ASN1_STRING_type(str));
p = (const char *)ASN1_STRING_get0_data(str);
- for (j = ASN1_STRING_length_ex(str); j > 0; j--) {
+ for (j = ASN1_STRING_get_length(str); j > 0; j--) {
if ((*p >= ' ') && (*p <= '~'))
BIO_printf(bio_err, "%c", *p);
else if (*p & 0x80)
diff --git a/apps/cms.c b/apps/cms.c
index b7f33945719..c52a4d1b182 100644
--- a/apps/cms.c
+++ b/apps/cms.c
@@ -1584,7 +1584,7 @@ static void receipt_request_print(CMS_ContentInfo *cms)
CMS_ReceiptRequest_get0_values(rr, &scid, &allorfirst,
&rlist, &rto);
BIO_puts(bio_err, " Signed Content ID:\n");
- idlen = ASN1_STRING_length_ex(scid);
+ idlen = ASN1_STRING_get_length(scid);
if (idlen > INT_MAX)
idlen = INT_MAX;
id = (const char *)ASN1_STRING_get0_data(scid);
diff --git a/apps/lib/apps.c b/apps/lib/apps.c
index 5d082992ec4..3b792b5768d 100644
--- a/apps/lib/apps.c
+++ b/apps/lib/apps.c
@@ -2830,7 +2830,7 @@ static const char *get_dp_url(DIST_POINT *dp)
for (i = 0; i < sk_GENERAL_NAME_num(gens); i++) {
gen = sk_GENERAL_NAME_value(gens, i);
uri = GENERAL_NAME_get0_value(gen, &gtype);
- if (gtype == GEN_URI && ASN1_STRING_length_ex(uri) > 6) {
+ if (gtype == GEN_URI && ASN1_STRING_get_length(uri) > 6) {
const char *uptr = (const char *)ASN1_STRING_get0_data(uri);
if (IS_HTTP(uptr)) /* can/should not use HTTPS here */
@@ -3719,7 +3719,7 @@ int has_stdin_waiting(void)
int corrupt_signature(ASN1_STRING *signature)
{
const unsigned char *valid = ASN1_STRING_get0_data(signature);
- size_t length = ASN1_STRING_length_ex(signature);
+ size_t length = ASN1_STRING_get_length(signature);
unsigned char *s = OPENSSL_memdup(valid, length);
if (s == NULL)
diff --git a/apps/lib/cmp_mock_srv.c b/apps/lib/cmp_mock_srv.c
index 825a2b6709e..c538c04d287 100644
--- a/apps/lib/cmp_mock_srv.c
+++ b/apps/lib/cmp_mock_srv.c
@@ -360,7 +360,7 @@ static OSSL_CMP_PKISI *process_cert_request(OSSL_CMP_SRV_CTX *srv_ctx,
ERR_raise(ERR_LIB_CMP, ERR_R_PASSED_INVALID_ARGUMENT);
return NULL;
}
- if (((len = ASN1_STRING_length_ex(str)) != sizeof("profile1") - 1)
+ if (((len = ASN1_STRING_get_length(str)) != sizeof("profile1") - 1)
|| memcmp(data, "profile1", len) != 0) {
ERR_raise(ERR_LIB_CMP, CMP_R_UNEXPECTED_CERTPROFILE);
return NULL;
diff --git a/apps/pkcs12.c b/apps/pkcs12.c
index e37aefc7a39..7c2c77d4ffb 100644
--- a/apps/pkcs12.c
+++ b/apps/pkcs12.c
@@ -833,7 +833,7 @@ int pkcs12_main(int argc, char **argv)
ASN1_INTEGER_get(pbkdf2_param->iter));
BIO_printf(bio_err, "Key length: %ld, Salt length: %d\n",
ASN1_INTEGER_get(pbkdf2_param->keylength),
- (int)ASN1_STRING_length_ex(pbkdf2_param->salt->value.octet_string));
+ (int)ASN1_STRING_get_length(pbkdf2_param->salt->value.octet_string));
if (pbkdf2_param->prf == NULL) {
prfnid = NID_hmacWithSHA1;
} else {
@@ -847,8 +847,8 @@ int pkcs12_main(int argc, char **argv)
BIO_printf(bio_err, ", Iteration %ld\n",
tmaciter != NULL ? ASN1_INTEGER_get(tmaciter) : 1L);
BIO_printf(bio_err, "MAC length: %ld, salt length: %ld\n",
- tmac != NULL ? (long)ASN1_STRING_length_ex(tmac) : 0L,
- tsalt != NULL ? (long)ASN1_STRING_length_ex(tsalt) : 0L);
+ tmac != NULL ? (long)ASN1_STRING_get_length(tmac) : 0L,
+ tsalt != NULL ? (long)ASN1_STRING_get_length(tsalt) : 0L);
}
}
@@ -1231,7 +1231,7 @@ static int alg_print(const X509_ALGOR *alg)
}
BIO_printf(bio_err, ", Salt length: %d, Cost(N): %ld, "
"Block size(r): %ld, Parallelism(p): %ld",
- (int)ASN1_STRING_length_ex(kdf->salt),
+ (int)ASN1_STRING_get_length(kdf->salt),
ASN1_INTEGER_get(kdf->costParameter),
ASN1_INTEGER_get(kdf->blockSize),
ASN1_INTEGER_get(kdf->parallelizationParameter));
@@ -1282,25 +1282,25 @@ void print_attribute(BIO *out, const ASN1_TYPE *av)
switch (av->type) {
case V_ASN1_BMPSTRING:
value = OPENSSL_uni2asc(ASN1_STRING_get0_data(av->value.bmpstring),
- (int)ASN1_STRING_length_ex(av->value.bmpstring));
+ (int)ASN1_STRING_get_length(av->value.bmpstring));
BIO_printf(out, "%s\n", value);
OPENSSL_free(value);
break;
case V_ASN1_UTF8STRING:
- BIO_printf(out, "%.*s\n", (int)ASN1_STRING_length_ex(av->value.utf8string),
+ BIO_printf(out, "%.*s\n", (int)ASN1_STRING_get_length(av->value.utf8string),
ASN1_STRING_get0_data(av->value.utf8string));
break;
case V_ASN1_OCTET_STRING:
hex_print(out, ASN1_STRING_get0_data(av->value.octet_string),
- (int)ASN1_STRING_length_ex(av->value.octet_string));
+ (int)ASN1_STRING_get_length(av->value.octet_string));
BIO_puts(out, "\n");
break;
case V_ASN1_BIT_STRING:
hex_print(out, ASN1_STRING_get0_data(av->value.bit_string),
- (int)ASN1_STRING_length_ex(av->value.bit_string));
+ (int)ASN1_STRING_get_length(av->value.bit_string));
BIO_puts(out, "\n");
break;
diff --git a/apps/s_client.c b/apps/s_client.c
index d64a2aa4e38..3817a6cc635 100644
--- a/apps/s_client.c
+++ b/apps/s_client.c
@@ -3097,7 +3097,7 @@ re_start:
BIO_puts(bio_err, "ASN1_generate_nconf failed\n");
goto end;
}
- ssl_request_len = ASN1_STRING_length_ex(atyp->value.sequence);
+ ssl_request_len = ASN1_STRING_get_length(atyp->value.sequence);
if (ssl_request_len > INT_MAX) {
NCONF_free(cnf);
ASN1_TYPE_free(atyp);