fix(version-check): honor settings and prevent stalled checks

- add a 30-second transfer timeout to version check requests
- read the host setting to respect update-check preferences
- avoid duplicated SDK string allocations and memory leaks
- simplify version state updates with reusable helpers

1 files changed, 3 insertions, 0 deletions

diff --git a/src/m_ver_check/GitHubVersionCheckTask.cpp b/src/m_ver_check/GitHubVersionCheckTask.cpp
index e0ba9d9..d2f8358 100644
--- a/src/m_ver_check/GitHubVersionCheckTask.cpp
+++ b/src/m_ver_check/GitHubVersionCheckTask.cpp
@@ -71,6 +71,9 @@ auto GitHubVersionCheckTask::Run() -> int {
   int index = 0;
   for (const QUrl& url : urls) {
     QNetworkRequest request(url);
+    // A check that never answers holds its task, and the tab waiting on it,
+    // for the rest of the run.
+    request.setTransferTimeout(30000);
     request.setHeader(QNetworkRequest::UserAgentHeader,
                       GFAppUserAgent(GFModuleSdkContext()));
     QNetworkReply* reply = network_manager_->get(request);