aboutsummaryrefslogtreecommitdiffstats
path: root/scd/app-piv.c
diff options
context:
space:
mode:
authorWerner Koch <[email protected]>2020-03-31 17:55:15 +0000
committerWerner Koch <[email protected]>2020-03-31 17:55:15 +0000
commit103c1576b73ed75b771a8ffd1c97628651b99797 (patch)
tree9b033d69d2e22bdb06d04d27e7347418afb26be1 /scd/app-piv.c
parentscd:p15: Read certificates in extended mode. (diff)
downloadgnupg-103c1576b73ed75b771a8ffd1c97628651b99797.tar.gz
gnupg-103c1576b73ed75b771a8ffd1c97628651b99797.zip
scd:p15: Support signing with CardOS 5 cards.
* scd/app-help.c (app_help_get_keygrip_string_pk): Add optional arg r_pkey and change all callers. (app_help_get_keygrip_string): Ditto. * scd/app-p15.c (struct cdf_object_s): Use bit flags (struct aodf_object_s): Ditto. Add field 'fid'. (struct prkdf_object_s): Ditto. Add fields keygrip, keyalgo, and keynbits. (parse_certid): Allow a keygrip instead of a certid aka keyref. (read_ef_aodf): Store the FID. (keygripstr_from_prkdf): Rename to ... (keygrip_from_prkdf): this. Remove arg r_gripstr and implement cache. Change callers to directly use the values from the object. Also store the algo and length of the key ion the object. (keyref_from_keyinfo): New. Factored out code. (do_sign): Support SHA-256 and >2048 bit RSA keys. (do_with_keygrip): New. (app_select_p15): Register new function. -- This has been tested with a D-Trust card featuring 3072 bit keys. Note that non-repudiation key for a qualified signature does not yet work because we do not yet support rsaPSS padding. Thus a gpgsm --learn shows a couple of Bad Signature errors for this key. Signed-off-by: Werner Koch <[email protected]>
Diffstat (limited to 'scd/app-piv.c')
-rw-r--r--scd/app-piv.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/scd/app-piv.c b/scd/app-piv.c
index 38608f47b..cd53c175f 100644
--- a/scd/app-piv.c
+++ b/scd/app-piv.c
@@ -1356,7 +1356,7 @@ get_keygrip_by_tag (app_t app, unsigned int tag,
err = ksba_cert_init_from_mem (cert, certbuf, certbuflen);
if (err)
goto leave;
- err = app_help_get_keygrip_string (cert, *r_keygripstr);
+ err = app_help_get_keygrip_string (cert, *r_keygripstr, NULL);
}
leave:
@@ -1564,7 +1564,7 @@ do_readkey (app_t app, ctrl_t ctrl, const char *keyrefstr, unsigned int flags,
char idbuf[50];
const char *usage;
- err = app_help_get_keygrip_string_pk (pk, pklen, keygripstr);
+ err = app_help_get_keygrip_string_pk (pk, pklen, keygripstr, NULL);
if (err)
{
log_error ("app_help_get_keygrip_string_pk failed: %s\n",