gpg: Add a notation with version information to signatures.

* common/compliance.c (gnupg_manu_notation_value): New.
* g10/build-packet.c (name_value_to_notation): New.
* g10/options.h (COMPAT_NO_MANU): New.
(LIST_SHOW_HIDDEN_NOTATIONS): New.
(VERIFY_SHOW_HIDDEN_NOTATIONS): New.
* g10/gpg.c (compatibility_flags): Add "no-manu".
(parse_list_options): Add "show-hidden-notations".
(main): Ditto for verify-options.
* g10/import.c (list_standalone_revocation): Implement new list option.
* g10/mainproc.c (check_sig_and_print):Ditto
* g10/keyedit.c (keyedit_print_one_sig): Ditto.
* g10/keylist.c (list_signature_print): Ditto.
(show_notation): Handle hidden notation.
* sm/keylist.c (oidtranstbl): Add OID for manu.
* g10/sign.c (mk_notation_policy_etc): Add arg with_manu and insert
extra notation.
(write_signature_packets): Request manu notation in certain cases.
(make_keysig_packet): Ditto.
--

See DETAILS for a description of the format.  Obviously this leaks the
version of the used GnuPG version (major and minor only) and the fact
that it was generated by GnuPG.  However, by close inspection of the
order of packets and and other meta data similar information can be
found.  We include this information to help the support desk to figure
out problems.  Sometimes users have very very old versions and the
help desk needs to employ core developers to figure the cause.  Having
this information may eventually allow for better user support.  This
feature can be disabled unless certain compliance modes are enabled.

1 files changed, 26 insertions, 9 deletions

diff --git a/g10/build-packet.c b/g10/build-packet.c
index 57a67d9f4..0eb83463f 100644
--- a/g10/build-packet.c
+++ b/g10/build-packet.c
@@ -1577,17 +1577,18 @@ notation_value_to_human_readable_string (struct notation *notation)
     return xstrdup (notation->value);
 }
 
-/* Turn the notation described by the string STRING into a notation.
-
-   STRING has the form:
 
-     - -name - Delete the notation.
-     - [email protected]=value - Normal notation
-     - [email protected]=value - Notation with critical bit set.
-
-   The caller must free the result using free_notation().  */
+/* Turn the notation described by the string STRING into a notation.
+ *
+ * STRING has the form:
+ *
+ *   - -name - Delete the notation.
+ *   - [email protected]=value - Normal notation
+ *   - [email protected]=value - Notation with critical bit set.
+ *
+ * The caller must free the result using free_notation().  */
 struct notation *
-string_to_notation(const char *string,int is_utf8)
+string_to_notation (const char *string, int is_utf8)
 {
   const char *s;
   int saw_at=0;
@@ -1676,6 +1677,22 @@ string_to_notation(const char *string,int is_utf8)
   return NULL;
 }
 
+
+/* Turn the notation described by NAME and VALUE into a notation.
+ * This will be a human readble non-critical notation.
+ * The caller must free the result using free_notation().  */
+struct notation *
+name_value_to_notation (const char *name, const char *value)
+{
+  struct notation *notation;
+
+  notation = xcalloc (1, sizeof *notation);
+  notation->name = xstrdup (name);
+  notation->value = xstrdup (value);
+  return notation;
+}
+
+
 /* Like string_to_notation, but store opaque data rather than human
    readable data.  */
 struct notation *