diff options
author | Werner Koch <[email protected]> | 2022-04-14 08:04:56 +0000 |
---|---|---|
committer | Werner Koch <[email protected]> | 2022-04-14 08:15:23 +0000 |
commit | 8ac92f0e807a3dfb6da46fdea1f9f2c89cc5ebc2 (patch) | |
tree | b4d1546a637ed759904c369c9e5afa907a965618 /scd/ccid-driver.c | |
parent | tests: Fix warning in common/t-ssh-utils.c (diff) | |
download | gnupg-8ac92f0e807a3dfb6da46fdea1f9f2c89cc5ebc2.tar.gz gnupg-8ac92f0e807a3dfb6da46fdea1f9f2c89cc5ebc2.zip |
scd: Fix memory leak in ccid-driver.
* scd/ccid-driver.c (ccid_dev_scan): Use loop var and not the count.
--
Due to an assignment out of bounds this might lead to a crash if there
are more than 15 readers. In any case it fixes a memory leak.
Kudos to the friendly auditor who found that bug.
Fixes-commit: 8a41e73c31adb86d4a7dca4da695e5ad1347811f
Diffstat (limited to 'scd/ccid-driver.c')
-rw-r--r-- | scd/ccid-driver.c | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/scd/ccid-driver.c b/scd/ccid-driver.c index 9d0d6ebe4..e06b659e1 100644 --- a/scd/ccid-driver.c +++ b/scd/ccid-driver.c @@ -1428,15 +1428,15 @@ ccid_dev_scan (int *idx_max_p, void **t_p) { for (i = 0; i < idx; i++) { - free (ccid_dev_table[idx].ifcdesc_extra); - ccid_dev_table[idx].n = 0; - ccid_dev_table[idx].interface_number = 0; - ccid_dev_table[idx].setting_number = 0; - ccid_dev_table[idx].ifcdesc_extra = NULL; - ccid_dev_table[idx].ifcdesc_extra_len = 0; - ccid_dev_table[idx].ep_bulk_out = 0; - ccid_dev_table[idx].ep_bulk_in = 0; - ccid_dev_table[idx].ep_intr = 0; + free (ccid_dev_table[i].ifcdesc_extra); + ccid_dev_table[i].n = 0; + ccid_dev_table[i].interface_number = 0; + ccid_dev_table[i].setting_number = 0; + ccid_dev_table[i].ifcdesc_extra = NULL; + ccid_dev_table[i].ifcdesc_extra_len = 0; + ccid_dev_table[i].ep_bulk_out = 0; + ccid_dev_table[i].ep_bulk_in = 0; + ccid_dev_table[i].ep_intr = 0; } libusb_free_device_list (ccid_usb_dev_list, 1); ccid_usb_dev_list = NULL; |