diff options
author | NIIBE Yutaka <[email protected]> | 2018-11-14 01:45:15 +0000 |
---|---|---|
committer | NIIBE Yutaka <[email protected]> | 2018-11-14 01:45:15 +0000 |
commit | 804a77edd9472d44606641b7772550521e1ba271 (patch) | |
tree | aab18cdca5e112b3fde741e19c0a4d90d5e500c4 /m4 | |
parent | dirmngr: Support the new WKD draft with the openpgpkey subdomain. (diff) | |
download | gnupg-804a77edd9472d44606641b7772550521e1ba271.tar.gz gnupg-804a77edd9472d44606641b7772550521e1ba271.zip |
agent: Simplify agent_popup_message_stop.
* agent/call-pinentry.c (agent_popup_message_stop): Just kill it.
--
By checking if it's alive or not, we can lower a risk of sending
SIGINT to a wrong process on unusual condition when PID is re-used to
a different process.
That's true, however, since it's alive usually, simply sending SIGINT
is enough here.
Note that here is a race condition for detecting if process is active
or not; A process can die just after being detected alive.
Moreover, when the process of pinentry accidentally died already, it
should have caused return of assuan_transact and the thread of
popup_message_thread likely already set popup_finished=1.
Signed-off-by: NIIBE Yutaka <[email protected]>
Diffstat (limited to 'm4')
0 files changed, 0 insertions, 0 deletions