diff options
| author | Werner Koch <[email protected]> | 2020-11-02 16:23:53 +0000 |
|---|---|---|
| committer | Werner Koch <[email protected]> | 2020-11-02 16:34:29 +0000 |
| commit | e1bafa3574ccd56d9f8f8c1deb3d8fb9fd7025cc (patch) | |
| tree | ea99746f2866c52a3a0173238eef57bbda5e89ee /g10/photoid.c | |
| parent | build: Remove m4 macro defs which are not anymore used. (diff) | |
| download | gnupg-e1bafa3574ccd56d9f8f8c1deb3d8fb9fd7025cc.tar.gz gnupg-e1bafa3574ccd56d9f8f8c1deb3d8fb9fd7025cc.zip | |
gpg: Allow setting notations with the empty string as value.
* g10/misc.c (pct_expando): Catch special case of the empty string.
Also map a NULL to the empty string.
* g10/photoid.c (show_photos): Make an empty string used as command
fail.
--
This patch also fixes a segv when calling gpg wrongly like
gpg -N \[email protected]
GnuPG-bug-id: 5117
Signed-off-by: Werner Koch <[email protected]>
Diffstat (limited to 'g10/photoid.c')
| -rw-r--r-- | g10/photoid.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/g10/photoid.c b/g10/photoid.c index 8a4436b8b..592d5e484 100644 --- a/g10/photoid.c +++ b/g10/photoid.c @@ -670,6 +670,11 @@ show_photos (ctrl_t ctrl, const struct user_attribute *attrs, int count, command = pct_expando (ctrl, opt.photo_viewer,&args); if(!command) goto fail; + if (!*command) + { + xfree (command); + goto fail; + } name = xmalloc (1 + 16 + strlen(EXTSEP_S) + strlen (image_type_to_string (args.imagetype, 0))); |