aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJakub Jelen <[email protected]>2024-05-28 14:50:59 +0000
committerWerner Koch <[email protected]>2024-05-28 14:50:59 +0000
commit379fc5569d604c4a7b5f12b2bbfc4106893c2a9e (patch)
tree717ce4b83185d0d5a4566d52c5cf2eb7f7031e75
parentagent: Avoid double free of empty string in the PIN caching. (diff)
downloadgnupg-379fc5569d604c4a7b5f12b2bbfc4106893c2a9e.tar.gz
gnupg-379fc5569d604c4a7b5f12b2bbfc4106893c2a9e.zip
agent: Avoid uninitialized access in GENKEY command on parameter error.
* agent/command.c (cmd_genkey): Moved init_membuf to the top. -- Signed-off-by: Jakub Jelen <[email protected]> This is part of GnuPG-bug-id: 7129
-rw-r--r--agent/command.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/agent/command.c b/agent/command.c
index b152a5ea4..417a8815f 100644
--- a/agent/command.c
+++ b/agent/command.c
@@ -1170,6 +1170,8 @@ cmd_genkey (assuan_context_t ctx, char *line)
int c;
unsigned int flags = 0;
+ init_membuf (&outbuf, 512);
+
if (ctrl->restricted)
return leave_cmd (ctx, gpg_error (GPG_ERR_FORBIDDEN));
@@ -1227,8 +1229,6 @@ cmd_genkey (assuan_context_t ctx, char *line)
if (rc)
goto leave;
- init_membuf (&outbuf, 512);
-
/* If requested, ask for the password to be used for the key. If
this is not used the regular Pinentry mechanism is used. */
if (opt_inq_passwd && !(flags & GENKEY_FLAG_NO_PROTECTION))