diff options
author | Ingo Klöcker <[email protected]> | 2023-01-03 11:15:19 +0000 |
---|---|---|
committer | Ingo Klöcker <[email protected]> | 2023-01-04 10:37:11 +0000 |
commit | 270d7523001a57a59ea0be617d8e71d4363e0d50 (patch) | |
tree | 9242c28cabc6893858e542f97663c81e021e4236 /lang/qt/src/encryptjob.cpp | |
parent | doc:python: Replace gpgme-config to pkg-config. (diff) | |
download | gpgme-270d7523001a57a59ea0be617d8e71d4363e0d50.tar.gz gpgme-270d7523001a57a59ea0be617d8e71d4363e0d50.zip |
qt: Explicitly instantiate private job classes
* lang/qt/src/Makefile.am: Add new files.
* lang/qt/src/changeexpiryjob_p.h, lang/qt/src/encryptjob_p.h,
lang/qt/src/importjob_p.h, lang/qt/src/listallkeysjob_p.h,
lang/qt/src/signencryptjob_p.h: New.
* lang/qt/src/changeexpiryjob.cpp, lang/qt/src/encryptjob.cpp,
lang/qt/src/importjob.cpp, lang/qt/src/listallkeysjob.cpp,
lang/qt/src/signencryptjob.cpp: Move JobPrivate subclasses to the new
private header files.
* lang/qt/src/job_p.h (jobPrivate): Remove lazy instantiation of private
job classes.
* lang/qt/src/qgpgmechangeexpiryjob.cpp (class
QGpgMEChangeExpiryJobPrivate): New.
(QGpgMEChangeExpiryJob::QGpgMEChangeExpiryJob): Instantiate private job
class.
* lang/qt/src/qgpgmeencryptjob.cpp (class
QGpgMEEncryptJobPrivate): New.
(QGpgMEEncryptJob::QGpgMEEncryptJob): Instantiate private job
class.
* lang/qt/src/qgpgmeimportjob.cpp (class
QGpgMEImportJobPrivate): New.
(QGpgMEImportJob::QGpgMEImportJob): Instantiate private job
class.
* lang/qt/src/qgpgmelistallkeysjob.cpp (class
QGpgMEListAllKeysJobPrivate): New.
(QGpgMEListAllKeysJob::QGpgMEListAllKeysJob): Instantiate private job
class.
* lang/qt/src/qgpgmesignencryptjob.cpp (class
QGpgMESignEncryptJobPrivate): New.
(QGpgMESignEncryptJob::QGpgMESignEncryptJob): Instantiate private job
class.
--
We need private job classes corresponding to the concrete leaf classes.
This makes the lazy instantiation of the private classes by the job
interface classes impossible.
GnuPG-bug-id: 6323
Diffstat (limited to 'lang/qt/src/encryptjob.cpp')
-rw-r--r-- | lang/qt/src/encryptjob.cpp | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/lang/qt/src/encryptjob.cpp b/lang/qt/src/encryptjob.cpp index 7533bd9d..7b9f0f2b 100644 --- a/lang/qt/src/encryptjob.cpp +++ b/lang/qt/src/encryptjob.cpp @@ -36,18 +36,10 @@ #endif #include "encryptjob.h" -#include "job_p.h" +#include "encryptjob_p.h" using namespace QGpgME; -namespace -{ -struct EncryptJobPrivate : public JobPrivate -{ - QString m_fileName; -}; -} - void EncryptJob::setFileName(const QString &fileName) { auto d = jobPrivate<EncryptJobPrivate>(this); |