GpgFrontend/gpgme
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qt: Update config sync doc / comment

Browse Source 
* lang/qt/src/cryptoconfig.h (CryptoConfig::sync): Document
that runtime option is always set.
* lang/qt/Src/qgpgmenewcryptoconfig.cpp
(QGpgMENewCryptoConfigComponent::sync): Remove outdated comment
and warn on error.
This commit is contained in:
Andre Heinecke 2017-01-02 14:03:08 +01:00
parent 7103315829
commit ececfd5de8
2 changed files with 6 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lang/qt/src/cryptoconfig.h
View File

@ -379,9 +379,8 @@ public:
/** /**
* Write back changes * Write back changes
* *
* @param runtime If this option is set, the changes will take effect at run-time, as * @param runtime this parameter is ignored. Changes will always
* far as this is possible. Otherwise, they will take effect at the next * be made with --runtime set.
* start of the respective backend programs.
*/ */
virtual void sync(bool runtime) = 0; virtual void sync(bool runtime) = 0;

13
lang/qt/src/qgpgmenewcryptoconfig.cpp
View File

@ -216,17 +216,12 @@ QGpgMENewCryptoConfigGroup *QGpgMENewCryptoConfigComponent::group(const QString
void QGpgMENewCryptoConfigComponent::sync(bool runtime) void QGpgMENewCryptoConfigComponent::sync(bool runtime)
{ {
Q_UNUSED(runtime) Q_UNUSED(runtime) // runtime is always set by engine_gpgconf
// ### how to pass --runtime to gpgconf? -> marcus: not yet supported (2010-11-20)
if (const Error err = m_component.save()) { if (const Error err = m_component.save()) {
#if 0 qCWarning(GPGPME_BACKEND_LOG) << ":"
TODO port << "Error from gpgconf while saving configuration: %1"
const QString wmsg = i18n("Error from gpgconf while saving configuration: %1", QString::fromLocal8Bit(err.asString())); << QString::fromLocal8Bit(err.asString());
qCWarning(GPGPME_BACKEND_LOG) << ":" << wmsg;
KMessageBox::error(0, wmsg);
#endif
} }
// ### unset dirty state again
} }
//// ////