From 5e21e61cfef809a7194ff94fb3aac525169a26b5 Mon Sep 17 00:00:00 2001 From: Daniel Kahn Gillmor Date: Tue, 4 Dec 2018 20:29:40 +0300 Subject: [PATCH] python: ctx.decrypt() has problematic error handling * lang/python/src/core.py (Context.decrypt): document odd error-handling behavior as a potential problem to be addressed. Signed-off-by: Daniel Kahn Gillmor --- lang/python/src/core.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lang/python/src/core.py b/lang/python/src/core.py index 3bd6f717..f3202eb1 100644 --- a/lang/python/src/core.py +++ b/lang/python/src/core.py @@ -427,6 +427,10 @@ class Context(GpgmeWrapper): results=results) if verify: + # FIXME: should we really throw BadSignature, even if + # we've encountered some good signatures? as above, once + # we hit this error, there is no way to accept it and + # continue to process the remaining signatures. if any(s.status != errors.NO_ERROR for s in verify_result.signatures): raise errors.BadSignatures(verify_result, results=results)