From 543e2106386f00ebecf7653e7896fa12a6e828ff Mon Sep 17 00:00:00 2001 From: Andre Heinecke Date: Mon, 4 Jan 2021 13:35:24 +0100 Subject: [PATCH] Qt: Undeprecate QByteArray based start functs * lang/qt/src/encryptjob.h, lang/qt/src/signjob.h (start): Undeprecate QByteArray based functions. -- While the QIODevice access might avoid a copy it is more difficult to manage the data and lifetime of the QIODevices in calling code. The QByteArray calls are convienient for small data objects like mails where an in memory copy is not really expensive anymore. --- lang/qt/src/encryptjob.h | 2 +- lang/qt/src/signjob.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lang/qt/src/encryptjob.h b/lang/qt/src/encryptjob.h index 161a7694..937ee8d6 100644 --- a/lang/qt/src/encryptjob.h +++ b/lang/qt/src/encryptjob.h @@ -90,7 +90,7 @@ public: not be performed, but full validity assumed for all keys without further checks. */ - virtual QGPGME_DEPRECATED_EXPORT GpgME::Error start(const std::vector &recipients, + virtual GpgME::Error start(const std::vector &recipients, const QByteArray &plainText, bool alwaysTrust = false) = 0; /*! diff --git a/lang/qt/src/signjob.h b/lang/qt/src/signjob.h index b5b5af6f..57d2d17b 100644 --- a/lang/qt/src/signjob.h +++ b/lang/qt/src/signjob.h @@ -85,7 +85,7 @@ public: Starts the signing operation. \a signers is the list of keys to sign \a plainText with. Empty (null) keys are ignored. */ - virtual QGPGME_DEPRECATED_EXPORT GpgME::Error start(const std::vector &signers, + virtual GpgME::Error start(const std::vector &signers, const QByteArray &plainText, GpgME::SignatureMode mode) = 0;