aboutsummaryrefslogtreecommitdiffstats
path: root/src/core/function
diff options
context:
space:
mode:
Diffstat (limited to 'src/core/function')
-rw-r--r--src/core/function/GlobalSettingStation.cpp8
-rw-r--r--src/core/function/gpg/GpgContext.cpp24
-rw-r--r--src/core/function/gpg/GpgContext.h6
3 files changed, 16 insertions, 22 deletions
diff --git a/src/core/function/GlobalSettingStation.cpp b/src/core/function/GlobalSettingStation.cpp
index d1c1068e..b54fbfd3 100644
--- a/src/core/function/GlobalSettingStation.cpp
+++ b/src/core/function/GlobalSettingStation.cpp
@@ -36,15 +36,13 @@
namespace GpgFrontend {
-class GlobalSettingStation::Impl
- : SingletonFunctionObject<GlobalSettingStation::Impl> {
+class GlobalSettingStation::Impl {
public:
/**
* @brief Construct a new Global Setting Station object
*
*/
- explicit Impl(int channel) noexcept
- : SingletonFunctionObject<GlobalSettingStation::Impl>(channel) {
+ explicit Impl() noexcept {
SPDLOG_INFO("app path: {}", app_path_.u8string());
SPDLOG_INFO("app configure path: {}", app_configure_path_.u8string());
SPDLOG_INFO("app data path: {}", app_data_path_.u8string());
@@ -269,7 +267,7 @@ class GlobalSettingStation::Impl
GlobalSettingStation::GlobalSettingStation(int channel) noexcept
: SingletonFunctionObject<GlobalSettingStation>(channel),
- p_(std::make_unique<Impl>(channel)) {}
+ p_(std::make_unique<Impl>()) {}
GlobalSettingStation::~GlobalSettingStation() noexcept = default;
diff --git a/src/core/function/gpg/GpgContext.cpp b/src/core/function/gpg/GpgContext.cpp
index f7223e13..7cde439c 100644
--- a/src/core/function/gpg/GpgContext.cpp
+++ b/src/core/function/gpg/GpgContext.cpp
@@ -280,14 +280,12 @@ class GpgContext::Impl {
assert(p_ctx != nullptr);
binary_ctx_ref_ = p_ctx;
- // if (!common_ctx_initialize(binary_ctx_ref_, args)) {
- // SPDLOG_ERROR("get new ctx failed, binary");
- // return false;
- // }
-
- // /** Setting the output type must be done at the beginning */
- // /** think this means ascii-armor --> ? */
- // gpgme_set_armor(binary_ctx_ref_, 0);
+ if (!common_ctx_initialize(binary_ctx_ref_, args)) {
+ SPDLOG_ERROR("get new ctx failed, binary");
+ return false;
+ }
+
+ gpgme_set_armor(binary_ctx_ref_, 0);
return true;
}
@@ -300,11 +298,11 @@ class GpgContext::Impl {
assert(p_ctx != nullptr);
ctx_ref_ = p_ctx;
- // if (!common_ctx_initialize(ctx_ref_, args)) {
- // return false;
- // }
+ if (!common_ctx_initialize(ctx_ref_, args)) {
+ return false;
+ }
- // gpgme_set_armor(ctx_ref_, 1);
+ gpgme_set_armor(ctx_ref_, 1);
return true;
}
};
@@ -313,7 +311,7 @@ GpgContext::GpgContext(int channel)
: SingletonFunctionObject<GpgContext>(channel),
p_(SecureCreateUniqueObject<Impl>(this, GpgContextInitArgs{})) {}
-GpgContext::GpgContext(const GpgContextInitArgs &args, int channel)
+GpgContext::GpgContext(GpgContextInitArgs args, int channel)
: SingletonFunctionObject<GpgContext>(channel),
p_(SecureCreateUniqueObject<Impl>(this, args)) {}
diff --git a/src/core/function/gpg/GpgContext.h b/src/core/function/gpg/GpgContext.h
index ead0c89b..16dd7c4a 100644
--- a/src/core/function/gpg/GpgContext.h
+++ b/src/core/function/gpg/GpgContext.h
@@ -55,13 +55,11 @@ struct GpgContextInitArgs {
*
*/
class GPGFRONTEND_CORE_EXPORT GpgContext
- : public QObject,
- public SingletonFunctionObject<GpgContext> {
- Q_OBJECT
+ : public SingletonFunctionObject<GpgContext> {
public:
explicit GpgContext(int channel);
- explicit GpgContext(const GpgContextInitArgs &args, int channel);
+ explicit GpgContext(GpgContextInitArgs args, int channel);
virtual ~GpgContext() override;