diff options
| author | Mario Limonciello <[email protected]> | 2025-04-22 23:48:29 +0000 |
|---|---|---|
| committer | Ingo Molnar <[email protected]> | 2025-04-26 09:41:16 +0000 |
| commit | 7094702a9e6d1256f1444ceff7be97414db51dbb (patch) | |
| tree | 474dd108677b60e4afe8265489bac5ea28450a58 | |
| parent | i2c: piix4, x86/platform: Move the SB800 PIIX4 FCH definitions to <asm/amd/fc... (diff) | |
| download | kernel-7094702a9e6d1256f1444ceff7be97414db51dbb.tar.gz kernel-7094702a9e6d1256f1444ceff7be97414db51dbb.zip | |
platform/x86/amd/pmc: Use FCH_PM_BASE definition
The s2idle MMIO quirk uses a scratch register in the FCH.
Adjust the code to clarify that.
Signed-off-by: Mario Limonciello <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
Cc: H. Peter Anvin <[email protected]>
Cc: Hans de Goede <[email protected]>
Cc: Ilpo Järvinen <[email protected]>
Cc: Shyam Sundar S K <[email protected]>
Cc: Yazen Ghannam <[email protected]>
Cc: [email protected]
Link: https://lore.kernel.org/r/[email protected]
| -rw-r--r-- | arch/x86/include/asm/amd/fch.h | 1 | ||||
| -rw-r--r-- | drivers/platform/x86/amd/pmc/pmc-quirks.c | 3 |
2 files changed, 3 insertions, 1 deletions
diff --git a/arch/x86/include/asm/amd/fch.h b/arch/x86/include/asm/amd/fch.h index 28972bd8f715..01ee15bcd25f 100644 --- a/arch/x86/include/asm/amd/fch.h +++ b/arch/x86/include/asm/amd/fch.h @@ -7,5 +7,6 @@ /* Register offsets from PM base: */ #define FCH_PM_DECODEEN 0x00 #define FCH_PM_DECODEEN_SMBUS0SEL GENMASK(20, 19) +#define FCH_PM_SCRATCH 0x80 #endif /* _ASM_X86_AMD_FCH_H_ */ diff --git a/drivers/platform/x86/amd/pmc/pmc-quirks.c b/drivers/platform/x86/amd/pmc/pmc-quirks.c index b4f49720c87f..b706b1f4d94b 100644 --- a/drivers/platform/x86/amd/pmc/pmc-quirks.c +++ b/drivers/platform/x86/amd/pmc/pmc-quirks.c @@ -11,6 +11,7 @@ #include <linux/dmi.h> #include <linux/io.h> #include <linux/ioport.h> +#include <asm/amd/fch.h> #include "pmc.h" @@ -20,7 +21,7 @@ struct quirk_entry { }; static struct quirk_entry quirk_s2idle_bug = { - .s2idle_bug_mmio = 0xfed80380, + .s2idle_bug_mmio = FCH_PM_BASE + FCH_PM_SCRATCH, }; static struct quirk_entry quirk_spurious_8042 = { |