diff options
| author | NIIBE Yutaka <[email protected]> | 2019-07-10 06:06:54 +0000 |
|---|---|---|
| committer | NIIBE Yutaka <[email protected]> | 2019-07-15 23:32:57 +0000 |
| commit | b7df72d3074b72cf8b537ac87416b6b719c1b1b7 (patch) | |
| tree | 08cb505d9deba3de2c127d0e000a168a8e8dd532 | |
| parent | doc: fix spelling (diff) | |
| download | gnupg-b7df72d3074b72cf8b537ac87416b6b719c1b1b7.tar.gz gnupg-b7df72d3074b72cf8b537ac87416b6b719c1b1b7.zip | |
gpg: Fix keyring retrieval.
* g10/keyring.c (keyring_get_keyblock): Avoid O(N^2) append.
--
Cherry-picking the master commit of:
a7a043e82555a9da984c6fb01bfec4990d904690
GnuPG-bug-id: 4592
Signed-off-by: NIIBE Yutaka <[email protected]>
| -rw-r--r-- | g10/keyring.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/g10/keyring.c b/g10/keyring.c index a8dd46265..f424f94fc 100644 --- a/g10/keyring.c +++ b/g10/keyring.c @@ -473,11 +473,14 @@ keyring_get_keyblock (KEYRING_HANDLE hd, KBNODE *ret_kb) } in_cert = 1; - node = lastnode = new_kbnode (pkt); + node = new_kbnode (pkt); if (!keyblock) - keyblock = node; + keyblock = lastnode = node; else - add_kbnode (keyblock, node); + { + lastnode->next = node; + lastnode = node; + } switch (pkt->pkttype) { case PKT_PUBLIC_KEY: |